Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754015AbbGWBkb (ORCPT ); Wed, 22 Jul 2015 21:40:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:26942 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbbGWBk0 (ORCPT ); Wed, 22 Jul 2015 21:40:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,527,1432623600"; d="scan'208";a="769530921" From: "Lu, Aaron" To: "m.othacehe@gmail.com" , "lenb@kernel.org" , "rjw@rjwysocki.net" CC: "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH] acpi-video: Fix brightness keys for Thinkpad X240 Thread-Topic: [PATCH] acpi-video: Fix brightness keys for Thinkpad X240 Thread-Index: AQHQxEKwHFOs08NQuUq4+UEJWISIH53nwtqA Date: Thu, 23 Jul 2015 01:40:18 +0000 Message-ID: <1437615709.11064.2.camel@intel.com> References: <1437544346-32285-1-git-send-email-m.othacehe@gmail.com> In-Reply-To: <1437544346-32285-1-git-send-email-m.othacehe@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.159.104] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6N1eps5017164 Content-Length: 1471 Lines: 45 On Wed, 2015-07-22 at 07:52 +0200, Mathieu OTHACEHE wrote: > Thinkpad X240 laptop has a working acpi_video backlight control but > using the default native backlight control, brightness keys does not > work. Is it because the events are not sent to user space? Can you please file a bug in https://bugzilla.kernel.org/ under the ACPI/Power-Video category and attach its acpidump/dmesg there? Thanks. Regards, Aaron > > This patch force acpi_video use for this laptop by adding an > exception in > video_detect_dmi_table. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/acpi/video_detect.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/acpi/video_detect.c > b/drivers/acpi/video_detect.c > index 815f75e..c4bc5f2 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -173,6 +173,14 @@ static const struct dmi_system_id > video_detect_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X201s"), > }, > }, > + { > + .callback = video_detect_force_video, > + .ident = "ThinkPad X240", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X240"), > + }, > + }, > > /* The native backlight controls do not work on some older > machines */ > {????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?