Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751888AbbGWGJK (ORCPT ); Thu, 23 Jul 2015 02:09:10 -0400 Received: from mga03.intel.com ([134.134.136.65]:43871 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbbGWGJH (ORCPT ); Thu, 23 Jul 2015 02:09:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,528,1432623600"; d="scan'208";a="767989015" Message-ID: <55B083C6.503@linux.intel.com> Date: Thu, 23 Jul 2015 14:03:50 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paolo Bonzini CC: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@redhat.com, bsd@redhat.com, lersek@redhat.com, jordan.l.justen@intel.com, edk2-devel@lists.sourceforge.net, Xiao Guangrong Subject: Re: [PATCH 3/3] KVM: x86: quirkily apply WB to all memory if cache is disabled References: <1436988356-4565-1-git-send-email-guangrong.xiao@linux.intel.com> <1436988356-4565-3-git-send-email-guangrong.xiao@linux.intel.com> <55B081F1.50406@redhat.com> In-Reply-To: <55B081F1.50406@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 28 On 07/23/2015 01:56 PM, Paolo Bonzini wrote: > > > On 15/07/2015 21:25, Xiao Guangrong wrote: >> From: Xiao Guangrong >> >> Current firmware depends on WB to fast boot, please refer to >> https://lkml.org/lkml/2015/7/12/115 >> >> Let's us WB if CR0.CD is set to make this kind of firmware happy >> >> This quirk can be dropped by using KVM_ENABLE_CAP API with >> KVM_CAP_DISABLE_QUIRKS if the broken firmware is gone >> >> Signed-off-by: Xiao Guangrong > > Your patch is actually *enabling* the quirk if KVM_QUIRK_CD_AS_WB is > included in the disabled quirks. I'm squashing in this change: Yep, i misunderstood the meaning of "disabled-quirks", thanks for your nice adjustment, Paolo! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/