Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbbGWGP0 (ORCPT ); Thu, 23 Jul 2015 02:15:26 -0400 Received: from mail-am1on0100.outbound.protection.outlook.com ([157.56.112.100]:23451 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750859AbbGWGPR (ORCPT ); Thu, 23 Jul 2015 02:15:17 -0400 From: Noam Camus To: Peter Hurley CC: "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" , "gregkh@linuxfoundation.org" , "jslaby@suse.com" Subject: RE: [PATCH 1/4] serial: 8250_dw: Add support for big-endian MMIO accesses Thread-Topic: [PATCH 1/4] serial: 8250_dw: Add support for big-endian MMIO accesses Thread-Index: AQHQxGHAfWeiqZU3OEehxJpUt8lgUp3naGoAgAAGQACAASX8QA== Date: Thu, 23 Jul 2015 06:15:14 +0000 Message-ID: References: <1437557699-25722-1-git-send-email-noamc@ezchip.com> <1437557699-25722-2-git-send-email-noamc@ezchip.com> <55AF8A34.2060900@hurleysoftware.com> <55AF8F72.6070000@hurleysoftware.com> In-Reply-To: <55AF8F72.6070000@hurleysoftware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hurleysoftware.com; dkim=none (message not signed) header.d=none; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB4PR02MB271;5:dnaCm0/HMTmthwf2eHpJkSURpXcp1PRWOh7k4ln+xfs5ufxd70hkuELTCwfOd2SOe701vjjYn8dWYWgjAkzz9kVfGeta7IOfyCGAHbF5+gMvWNxe3mSegEXoDT0pMCeIQZBqf2GqB+OQ9+uzwX8K1w==;24:qBBP9goltj/ZlKPQuy7bhTiPw5cgv99r/b/ATq20C+8d2RlZrLaAokoB8hEerxumN2ad3Orsv1PtoIksKa8q2/ZCSXg304HOy81j0WGgIZc=;20:N5jl6bmvPv2/YCDGKlkEFM8S+HW7I3hjhM/n/EqBMKlw3M+1WW6zZ/MO8FYqgxfZEPE//HaauqE3hUkjQP8cFg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB271; db4pr02mb271: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB4PR02MB271;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB271; x-forefront-prvs: 06469BCC91 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(377454003)(19580395003)(106116001)(2950100001)(77156002)(50986999)(5003600100002)(74316001)(189998001)(62966003)(102836002)(5001960100002)(575784001)(46102003)(2900100001)(40100003)(54356999)(122556002)(77096005)(87936001)(2656002)(76576001)(86362001)(110136002)(33656002)(92566002)(66066001)(5002640100001)(76176999)(93886004)(19580405001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR02MB271;H:DB4PR02MB272.eurprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2015 06:15:14.3639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB271 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6N6FVW6019159 Content-Length: 902 Lines: 20 From: Peter Hurley [mailto:peter@hurleysoftware.com] Sent: Wednesday, July 22, 2015 3:41 PM >> diff --git a/drivers/tty/serial/8250/8250_dw.c >> b/drivers/tty/serial/8250/8250_dw.c >> index d48b506..fe0b487 100644 >> --- a/drivers/tty/serial/8250/8250_dw.c >> +++ b/drivers/tty/serial/8250/8250_dw.c >> @@ -173,15 +173,13 @@ static void dw8250_serial_outq(struct uart_port >> *p, int offset, int value) } #endif /* CONFIG_64BIT */ >> >> -static void dw8250_serial_out32(struct uart_port *p, int offset, int >> value) >> +static void dw8250_check_control(struct uart_port *p, int offset, >> +int value) > Also, I think this fn name should be dw8250_check_LCR() to distinguish it from modem control. No problem will rename in my v2 ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?