Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752676AbbGWGvb (ORCPT ); Thu, 23 Jul 2015 02:51:31 -0400 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:38060 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbGWGvZ convert rfc822-to-8bit (ORCPT ); Thu, 23 Jul 2015 02:51:25 -0400 From: Naoya Horiguchi To: Vlastimil Babka CC: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "minkyung88.kim" , "kmk3210@gmail.com" , Seungho Park , Joonsoo Kim , Minchan Kim , Michal Nazarewicz , Laura Abbott , "Kirill A. Shutemov" , Mel Gorman , "Johannes Weiner" Subject: Re: [PATCH 2/2] mm: rename and move get/set_freepage_migratetype Thread-Topic: [PATCH 2/2] mm: rename and move get/set_freepage_migratetype Thread-Index: AQHQw7Rl/KIgLPjDAUK+Hyojg1Gx+p3m1bkAgAEzDoA= Date: Thu, 23 Jul 2015 06:48:08 +0000 Message-ID: <20150723064806.GC16668@hori1.linux.bs1.fc.nec.co.jp> References: <55969822.9060907@suse.cz> <1437483218-18703-1-git-send-email-vbabka@suse.cz> <1437483218-18703-2-git-send-email-vbabka@suse.cz> <55AF8C94.6020406@suse.cz> In-Reply-To: <55AF8C94.6020406@suse.cz> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.7] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <7C22623600D23D4DA44DC07E854D4946@gisp.nec.co.jp> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2896 Lines: 56 On Wed, Jul 22, 2015 at 02:29:08PM +0200, Vlastimil Babka wrote: > On 07/21/2015 02:53 PM, Vlastimil Babka wrote: > > The pair of get/set_freepage_migratetype() functions are used to cache > > pageblock migratetype for a page put on a pcplist, so that it does not have > > to be retrieved again when the page is put on a free list (e.g. when pcplists > > become full). Historically it was also assumed that the value is accurate for > > pages on freelists (as the functions' names unfortunately suggest), but that > > cannot be guaranteed without affecting various allocator fast paths. It is in > > fact not needed and all such uses have been removed. > > > > The last remaining (but pointless) usage related to pages of freelists is in > > move_freepages(), which this patch removes. > > I realized there's one more callsite that can be removed. Here's > whole updated patch due to different changelog and to cope with > context changed by the fixlet to patch 1/2. > > ------8<------ > From: Vlastimil Babka > Date: Thu, 2 Jul 2015 16:37:06 +0200 > Subject: mm: rename and move get/set_freepage_migratetype > > The pair of get/set_freepage_migratetype() functions are used to cache > pageblock migratetype for a page put on a pcplist, so that it does not have > to be retrieved again when the page is put on a free list (e.g. when pcplists > become full). Historically it was also assumed that the value is accurate for > pages on freelists (as the functions' names unfortunately suggest), but that > cannot be guaranteed without affecting various allocator fast paths. It is in > fact not needed and all such uses have been removed. > > The last two remaining (but pointless) usages related to pages of freelists > are removed by this patch: > - move_freepages() which operates on pages already on freelists > - __free_pages_ok() which puts a page directly to freelist, bypassing pcplists > > To prevent further confusion, rename the functions to > get/set_pcppage_migratetype() and expand their description. Since all the > users are now in mm/page_alloc.c, move the functions there from the shared > header. > > Signed-off-by: Vlastimil Babka > Acked-by: David Rientjes > Cc: Joonsoo Kim > Cc: Minchan Kim > Cc: Michal Nazarewicz > Cc: Laura Abbott > Cc: Naoya Horiguchi > Cc: Kirill A. Shutemov > Cc: Mel Gorman > Cc: Johannes Weiner Reviewed-by: Naoya Horiguchi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/