From: Kukjin Kim <kgene@kernel.org>
To: "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>,
        "'Kukjin Kim'" <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "=?UTF-8?Q?'Bart=C5=82omiej_=C5=BBo=C5=82nierkiewicz'?=" 
	<b.zolnierkie@samsung.com>
References: <1437014519-19571-1-git-send-email-k.kozlowski@samsung.com>
 <1437014519-19571-2-git-send-email-k.kozlowski@samsung.com>
 <06bb01d0c372$756f2250$604d66f0$@kernel.org>
 <CAJKOXPeHu7WB7ZJJsjMSPXgiB24ryqufSuPDhFxiXoYDMjLHcg@mail.gmail.com>
 <CAJKOXPeJyoG1sw_Oxznx75WPrk2CcQMxtXrq_MiPHm15E7k+8g@mail.gmail.com>
 <55AED996.9090208@samsung.com>
In-reply-to: <55AED996.9090208@samsung.com>
Subject: RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3
Date: Thu, 23 Jul 2015 16:58:16 +0900
Message-id: <028b01d0c51d$553710e0$ffa532a0$@kernel.org>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 7bit
Thread-index: AQDQkAuFQPsoZO/QEfvsSFkOZao/bwFCDRLSAicUe8gBkYeGRgFmmE2tAheL72KfpVN/MA==
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2270
Lines: 65

Krzysztof Kozlowski wrote:
> 
> On 21.07.2015 14:21, Krzysztof Kozlowski wrote:
> > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> >>> Krzysztof Kozlowski wrote:

[...]

> >>>> --
> >>>
> >>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
> >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.
> >
> > Cc-ed Bartlomiej,
> >
> > One issue found: splitting DTS change for Exynos 5250 cpufreq to
> > separate branch will break bisectability. The commit "ARM: dts:
> > Exynos5250: add CPU OPP and regulator supply property":
> > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock
> > configuration data and instantiate cpu clock" to prevent build
> > failures,
> > 2. should be put before "ARM: Exynos: switch to using generic cpufreq
> > driver for Exynos5250" to prevent lost cpufreq functionality.
> >
> > Doing otherwise would lose bisectability which is really unfortunate
> > when you can simply avoid it. This should remain in the same branch -
> > next/cpufreq-clk-samsung.
> 
> Dear Kukjin,
> 
> Nothing changed since yesterday... so let me point this in a more clear
> way. The way you divided the patchset causes build errors:
> 
> --------------
> HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator
> supply property for exynos5250
> 
> ERROR: Failed build: -A arm -c exynos on
> 565872a601c4d91a75b917b1fb40ff27ad7ebb08
> 
> LOGS:
> Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
> make[1]: *** [dtbs] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
> --------------
> 
> This breaks bisectability without any special valid reason.
> 
Hi,

I couldn't check e-mail yesterday because of annual health check.
Anyway, I'll look at the error and handle it soon.

Thanks for your check.
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/