Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbbGWIL2 (ORCPT ); Thu, 23 Jul 2015 04:11:28 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51926 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751392AbbGWILY (ORCPT ); Thu, 23 Jul 2015 04:11:24 -0400 X-AuditID: cbfee68d-f79106d00000728c-b8-55b0a1aaa82f From: Kukjin Kim To: "'Kukjin Kim'" , "'Krzysztof Kozlowski'" Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, "=?UTF-8?Q?'Bart=C5=82omiej_=C5=BBo=C5=82nierkiewicz'?=" References: <1437014519-19571-1-git-send-email-k.kozlowski@samsung.com> <1437014519-19571-2-git-send-email-k.kozlowski@samsung.com> <06bb01d0c372$756f2250$604d66f0$@kernel.org> <55AED996.9090208@samsung.com> <028b01d0c51d$553710e0$ffa532a0$@kernel.org> In-reply-to: <028b01d0c51d$553710e0$ffa532a0$@kernel.org> Subject: RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Date: Thu, 23 Jul 2015 17:11:21 +0900 Message-id: <02f701d0c51f$29219870$7b64c950$@kernel.org> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQDQkAuFQPsoZO/QEfvsSFkOZao/bwFCDRLSAicUe8gBkYeGRgFmmE2tAheL72IChc8AhJ+RJxlA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t8zA91VCzeEGtxcwmKxccZ6VovXLwwt +h+/ZrbY9Pgaq8XlXXPYLGac38fkwOaxaVUnm8fmJfUefVtWMXp83iQXwBLFZZOSmpNZllqk b5fAldE55z5rwTaRiv8vjrA0MK4V6GLk5JAQMJGYuXwBI4QtJnHh3nq2LkYuDiGBZYwSXUem sMAUXVp6iBEiMZ1R4t+uhywQzntGiSNvn7N3MXJwsAkoSzQ26YM0CAtoSSzc0gTWLCIQJrHi 4VZmEJtZ4BCjxJmtOhC9E5gl5nZsBktwClhK3F2+nxmi2V7i4Z21YCexCKhK9LXtAhvEK2Ah 8eXBHChbUOLH5HssEEPVJSbNWwS1QF5i85q3zBBXK0jsOPuaEeKIGImmX+dZIWpEJPa9eAf2 jYTAPXaJ9z/aWCGWCUh8m3yIBeQZCQFZiU0HoOZIShxccYNlAqPkLCSrZyFZPQvJ6llIVixg ZFnFKJpakFxQnJReZKhXnJhbXJqXrpecn7uJERLBvTsYbx+wPsQowMGoxMP702dDqBBrYllx Ze4hRlOgiyYyS4km5wPTRF5JvKGxmZGFqYmpsZG5pZmSOK+i1M9gIYH0xJLU7NTUgtSi+KLS nNTiQ4xMHJxSDYzdfWoblyVvyrHe5pYhKzBbgnn30rrpHxjmSbl8Wn2Qm8uEudF+2cUJj9XZ kiZvm/oy19/lCk/WEZv4TBlFpZNGNr+/x994IXw92fyM94yZfvmc538z3dRy1bB/kh7Cskj+ wG3NaYePmS944f8kMXBDMYOFkTzTpX0Xj3h/PXDhW8abvWz7NUSUWIozEg21mIuKEwHva7WR 2wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jQd2VCzeEGqxpsbXYOGM9q8XrF4YW /Y9fM1tsenyN1eLyrjlsFjPO72NyYPPYtKqTzWPzknqPvi2rGD0+b5ILYIlqYLTJSE1MSS1S SM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAdqtpFCWmFMKFApILC5W 0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsY8zonHOftWCbSMX/F0dYGhjXCnQxcnJICJhIXFp6 iBHCFpO4cG89WxcjF4eQwHRGiX+7HrJAOO8ZJY68fc7excjBwSagLNHYpA/SICygJbFwSxML iC0iECax4uFWZhCbWeAQo8SZrToQvROYJeZ2bAZLcApYStxdvp8Zotle4uGdtWCbWQRUJfra doEN4hWwkPjyYA6ULSjxY/I9Foih6hKT5i2CWiAvsXnNW2aIqxUkdpx9zQhxRIxE06/zrBA1 IhL7XrxjnMAoPAvJqFlIRs1CMmoWkpYFjCyrGEVTC5ILipPSc430ihNzi0vz0vWS83M3MYLT wzPpHYyrGiwOMQpwMCrx8P7w2RAqxJpYVlyZC/Q5B7OSCO+V+UAh3pTEyqrUovz4otKc1OJD jKZAn05klhJNzgemrrySeENjEzMjSyMzCyMTc3Mlcd6T+T6hQgLpiSWp2ampBalFMH1MHJxS DYyKb3OuP+XYtcA8yMLTIeVjI/8+8+edn5Mz5J9U+e6a85L3X7DS+gsXBJukDW1mhiitn/K/ uparM8Pl7LzC/YXX1C7HLFjTe/yHvaQmB2PSnZV3LeIt7eraDatjtOTt+GY6Lrh1pDZL8kJ7 wtaCQ7aOupJTW5JX7Lz6P+DbItfq6XrfnTvuMyixFGckGmoxFxUnAgBYGiPPJQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2789 Lines: 75 Kukjin Kim wrote: > > Krzysztof Kozlowski wrote: > > > > On 21.07.2015 14:21, Krzysztof Kozlowski wrote: > > > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski : > > >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim : > > >>> Krzysztof Kozlowski wrote: > > [...] > > > >>>> -- > > >>> > > >>> Applied above changes into fixes/non-critical, next/cleanup-samsung, > > >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change. > > > > > > Cc-ed Bartlomiej, > > > > > > One issue found: splitting DTS change for Exynos 5250 cpufreq to > > > separate branch will break bisectability. The commit "ARM: dts: > > > Exynos5250: add CPU OPP and regulator supply property": > > > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock > > > configuration data and instantiate cpu clock" to prevent build > > > failures, > > > 2. should be put before "ARM: Exynos: switch to using generic cpufreq > > > driver for Exynos5250" to prevent lost cpufreq functionality. > > > > > > Doing otherwise would lose bisectability which is really unfortunate > > > when you can simply avoid it. This should remain in the same branch - > > > next/cpufreq-clk-samsung. > > > > Dear Kukjin, > > > > Nothing changed since yesterday... so let me point this in a more clear > > way. The way you divided the patchset causes build errors: > > > > -------------- > > HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator > > supply property for exynos5250 > > > > ERROR: Failed build: -A arm -c exynos on > > 565872a601c4d91a75b917b1fb40ff27ad7ebb08 > > > > LOGS: > > Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error > > FATAL ERROR: Unable to parse input tree > > make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1 > > make[1]: *** [dtbs] Error 2 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [sub-make] Error 2 > > -------------- > > > > This breaks bisectability without any special valid reason. > > > Hi, > > I couldn't check e-mail yesterday because of annual health check. > Anyway, I'll look at the error and handle it soon. > OK, the change for the include/dt-bindings/clock/exynos5250.h file which is in next/cpufreq-clk-samsung branch should be provided in next/dt-samsung branch. It should be fine tonight in my time. One more thing, the splitting changes into dt and driver side would be required generally and if it has dependency like this, proper merge topic branch is required by maintainer. But I've missed last action :( Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/