Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752630AbbGWIQi (ORCPT ); Thu, 23 Jul 2015 04:16:38 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48101 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbbGWIPj (ORCPT ); Thu, 23 Jul 2015 04:15:39 -0400 Date: Thu, 23 Jul 2015 10:15:28 +0200 From: Peter Zijlstra To: Hidehiro Kawai Cc: Jonathan Corbet , Ingo Molnar , "Eric W. Biederman" , "H. Peter Anvin" , Andrew Morton , Thomas Gleixner , Vivek Goyal , linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Ingo Molnar , Masami Hiramatsu Subject: Re: [PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI Message-ID: <20150723081528.GG25159@twins.programming.kicks-ass.net> References: <20150722021421.5155.74460.stgit@softrs> <20150722021421.5155.9710.stgit@softrs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150722021421.5155.9710.stgit@softrs> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 441 Lines: 10 On Wed, Jul 22, 2015 at 11:14:21AM +0900, Hidehiro Kawai wrote: > +DEFINE_SPINLOCK(panic_lock); At the very least this should be a raw spinlock, but wth aren't you using a simple atomic_xchg() ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/