Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406AbbGWInV (ORCPT ); Thu, 23 Jul 2015 04:43:21 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:35497 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbbGWInP (ORCPT ); Thu, 23 Jul 2015 04:43:15 -0400 MIME-Version: 1.0 X-Originating-IP: [37.11.3.119] In-Reply-To: <1437622799-28115-2-git-send-email-henryc.chen@mediatek.com> References: <1437622799-28115-1-git-send-email-henryc.chen@mediatek.com> <1437622799-28115-2-git-send-email-henryc.chen@mediatek.com> Date: Thu, 23 Jul 2015 10:43:14 +0200 Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator From: Javier Martinez Canillas To: Henry Chen Cc: Mark Brown , Mark Rutland , Liam Girdwood , Linux Kernel , linux-mediatek@lists.infradead.org, Sascha Hauer , Matthias Brugger , eddie.huang@mediatek.com, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2746 Lines: 76 Hello Henry, On Thu, Jul 23, 2015 at 5:39 AM, Henry Chen wrote: > This patch adds a list of supported regulator names to the devicetree > binding documentation for Mediatek MT6311 PMIC. > > Signed-off-by: Henry Chen > --- > .../bindings/regulator/mt6311-regulator.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/regulator/mt6311-regulator.txt > > diff --git a/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt > new file mode 100644 > index 0000000..9387d6d > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mt6311-regulator.txt > @@ -0,0 +1,35 @@ > +Mediatek MT6311 Regulator Driver > + > +Required properties: > +- compatible: "mediatek,mt6311-regulator" > +- reg: I2C slave address, usually 0x6b. > +- regulators: List of regulators provided by this controller. It is named > + to VDVFS and VBIASN. > + The definition for each of these nodes is defined using the standard binding > + for regulators at Documentation/devicetree/bindings/regulator/regulator.txt. > + > +The valid names for regulators are: > +BUCK: > + VDVFS > +LDO: > + VBIASN > + > +Example: Sorry, I missed this in the previous revision but the ePAPR document says "the name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model." > + pmic: mt6311@6B { So this should be: mt6311: pmic@ > + compatible = "mediatek,mt6311-regulator"; > + reg = <0x6B>; > + > + regulators { > + mt6311_vcpu_reg: VDVFS { > + regulator-name = "VDVFS"; > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1400000>; > + regulator-ramp-delay = <10000>; > + }; > + mt6311_ldo_reg: VBIASN { > + regulator-name = "VBIASN"; > + regulator-min-microvolt = <200000>; > + regulator-max-microvolt = <800000>; > + }; > + }; > + }; > -- Besides the comment above, it looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/