Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbbGWI72 (ORCPT ); Thu, 23 Jul 2015 04:59:28 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:33255 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbbGWI7W (ORCPT ); Thu, 23 Jul 2015 04:59:22 -0400 X-IronPort-AV: E=Sophos;i="5.15,529,1432598400"; d="scan'208";a="286784759" Message-ID: <55B0ACE6.2080805@citrix.com> Date: Thu, 23 Jul 2015 10:59:18 +0200 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bob Liu , CC: , , Subject: Re: [PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent References: <1437547210-32573-1-git-send-email-bob.liu@oracle.com> <1437547210-32573-2-git-send-email-bob.liu@oracle.com> In-Reply-To: <1437547210-32573-2-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 21 El 22/07/15 a les 8.40, Bob Liu ha escrit: > We should consider info->feature_persistent when adding indriect page to list ^ indirect > info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered. > > Signed-off-by: Bob Liu Thanks, this looks correct indeed. If we are using persistent grants the indirect_pages list should always be empty because blkfront has pre-allocated enough persistent pages to fill all requests on the ring. Acked-by: Roger Pau Monn? Should be backported to stable branches. Roger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/