Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752428AbbGWJAe (ORCPT ); Thu, 23 Jul 2015 05:00:34 -0400 Received: from smtp.citrix.com ([66.165.176.89]:49716 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbbGWJAZ (ORCPT ); Thu, 23 Jul 2015 05:00:25 -0400 X-IronPort-AV: E=Sophos;i="5.15,529,1432598400"; d="scan'208";a="283613725" Message-ID: <55B0AD25.6010904@citrix.com> Date: Thu, 23 Jul 2015 11:00:21 +0200 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Bob Liu , CC: , , Subject: Re: [PATCH v2 1/3] xen-blkfront: introduce blkfront_gather_backend_features() References: <1437547210-32573-1-git-send-email-bob.liu@oracle.com> In-Reply-To: <1437547210-32573-1-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 27 El 22/07/15 a les 8.40, Bob Liu ha escrit: > There is a bug when migrate from !feature-persistent host to feature-persistent > host, because domU still thinks new host/backend doesn't support persistent. > Dmesg like: > backed has not unmapped grant: 839 > backed has not unmapped grant: 773 > backed has not unmapped grant: 773 > backed has not unmapped grant: 773 > backed has not unmapped grant: 839 > > The fix is to recheck feature-persistent of new backend in blkif_recover(). > See: https://lkml.org/lkml/2015/5/25/469 > > As Roger suggested, we can split the part of blkfront_connect that checks for > optional features, like persistent grants, indirect descriptors and > flush/barrier features to a separate function and call it from both > blkfront_connect and blkif_recover > > Signed-off-by: Bob Liu Acked-by: Roger Pau Monn? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/