Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbbGWJlS (ORCPT ); Thu, 23 Jul 2015 05:41:18 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:47602 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbbGWJlK (ORCPT ); Thu, 23 Jul 2015 05:41:10 -0400 Date: Thu, 23 Jul 2015 02:41:09 -0700 From: Christoph Hellwig To: Spencer Baugh Cc: "Nicholas A. Bellinger" , "open list:TARGET SUBSYSTEM" , "open list:TARGET SUBSYSTEM" , open list , Joern Engel , Spencer Baugh , Roland Dreier Subject: Re: [PATCH] target: respond to unknown initiators with sensible REPORT LUNS list length Message-ID: <20150723094109.GF5382@infradead.org> References: <1437602898-15229-3-git-send-email-sbaugh@catern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437602898-15229-3-git-send-email-sbaugh@catern.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 585 Lines: 17 On Wed, Jul 22, 2015 at 03:08:17PM -0700, Spencer Baugh wrote: > done: > + /* > + * If no real LUNs are accessible, report an allocation length > + * of 1 LUN to account for virtual LUN 0. > + */ > + if (lun_count == 0) > + lun_count = 1; > + Shouldn't the code actually report the virtual lun zero instead of just accounting for it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/