Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbbGWKSv (ORCPT ); Thu, 23 Jul 2015 06:18:51 -0400 Received: from ozlabs.org ([103.22.144.67]:42158 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916AbbGWKSp (ORCPT ); Thu, 23 Jul 2015 06:18:45 -0400 In-Reply-To: <1437418902-23324-1-git-send-email-tim.gardner@canonical.com> To: Tim Gardner , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Michael Ellerman Cc: Tim Gardner Subject: Re: [4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure Message-Id: <20150723101844.9D3F0140D19@ozlabs.org> Date: Thu, 23 Jul 2015 20:18:44 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 23 On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote: > From: Tim Gardner > > drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class > module_init(anslcd_init); > ^ > drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] > > gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1) Thanks Tim but Luis beat you to it: http://patchwork.ozlabs.org/patch/497138/ I'll send the fix to Linus in the next day or two. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/