From: Noam Camus <noamc@ezchip.com>
To: Peter Hurley <peter@hurleysoftware.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
        "vgupta@synopsys.com" <vgupta@synopsys.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jslaby@suse.com" <jslaby@suse.com>
Subject: RE: [PATCH 3/4] serial: 8250_dw: Add UPF_FIXED_TYPE to flags
Thread-Topic: [PATCH 3/4] serial: 8250_dw: Add UPF_FIXED_TYPE to flags
Thread-Index: AQHQxGHTWKbo18/wBkKExeAnUuVvRJ3nbf+AgAEo/tA=
Date: Thu, 23 Jul 2015 10:38:11 +0000
Message-ID: <DB4PR02MB272A2301DF424A030948E78D6820@DB4PR02MB272.eurprd02.prod.outlook.com>
References: <1437557699-25722-1-git-send-email-noamc@ezchip.com>
 <1437557699-25722-2-git-send-email-noamc@ezchip.com>
 <1437557699-25722-3-git-send-email-noamc@ezchip.com>
 <1437557699-25722-4-git-send-email-noamc@ezchip.com>
 <55AF8EE3.1040406@hurleysoftware.com>
In-Reply-To: <55AF8EE3.1040406@hurleysoftware.com>
Accept-Language: en-US
Content-Language: en-US
db4pr02mb269: X-MS-Exchange-Organization-RulesExecuted
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2015 10:38:11.7499
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB269
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6NAcfYE020572
Content-Length: 1295
Lines: 30

From: Peter Hurley [mailto:peter@hurleysoftware.com] 
Sent: Wednesday, July 22, 2015 3:39 PM

>> +	/* Writing to LCR may cause BUSY interrupt before we
>> +	 * register the IRQ line.
>> +	 * Currently autoconf() uses several writes to LCR.
>> +	 * In order to avoid calling to autoconf() always add
>> +	 * following flag.
>> +	 */
>> +	p->flags |= UPF_FIXED_TYPE; 
>
> Why only for devicetree DW8250's?  Don't all DW8250's have this LCR "feature"?
>
Yes, all DW8250 got this "feature" i.e. busy functionality.

> And what port type does this id DW8250's as, PORT_8250? Except with fifos, autoflow control, dma, etc.?
The only thing that DW8250 is not fully 16550 compatibility is this busy functionality feature.
This feature means that a serial transfer is in progress.
It is indicated by special identification in IIR, and raised when LCR is written while device is busy.

> If the port type is being fixed, then please fix it to a new port type.
As an extension to 16550 type is not fixed.

Seem that I need to rethink on this.
I will remove this commit from v2 patch set till I will be sure what is the right thing to do.

Noam


????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?