Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753418AbbGWKkr (ORCPT ); Thu, 23 Jul 2015 06:40:47 -0400 Received: from mail-db3on0062.outbound.protection.outlook.com ([157.55.234.62]:51803 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753192AbbGWKkj (ORCPT ); Thu, 23 Jul 2015 06:40:39 -0400 From: Noam Camus To: Peter Hurley CC: "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , "Alexey.Brodkin@synopsys.com" , "vgupta@synopsys.com" , "gregkh@linuxfoundation.org" , "jslaby@suse.com" Subject: RE: [PATCH 4/4] serial: 8250_dw: use serial_in() and not readl() Thread-Topic: [PATCH 4/4] serial: 8250_dw: use serial_in() and not readl() Thread-Index: AQHQxGHUZgQZZXG0gk6izRDgnH+Zlp3ncZgAgAFtCSA= Date: Thu, 23 Jul 2015 10:40:36 +0000 Message-ID: References: <1437557699-25722-1-git-send-email-noamc@ezchip.com> <1437557699-25722-2-git-send-email-noamc@ezchip.com> <1437557699-25722-3-git-send-email-noamc@ezchip.com> <1437557699-25722-4-git-send-email-noamc@ezchip.com> <1437557699-25722-5-git-send-email-noamc@ezchip.com> <55AF91E8.3020903@hurleysoftware.com> In-Reply-To: <55AF91E8.3020903@hurleysoftware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: hurleysoftware.com; dkim=none (message not signed) header.d=none; x-originating-ip: [212.179.42.66] x-microsoft-exchange-diagnostics: 1;DB4PR02MB272;5:G1cw6UtItGBQ+2wBDi8CFcfosBC4TITzHBtlV449Knxo3WeWHNL2ltNpwTDBngxjVGSzQUOEMM7zgvmaI/ewt7372A0tk3nfzCqOfGB/bpspNtxFwf1rGtfOhEPCkrOLXJlGaEY+unnGFRD5HAMHcA==;24:qsYiEDoe+weiUipU+GVYKbKcWXBkIluoqlL2PrV3G5bw8wzkBgdx04LddP6GnbqLoeZpTPwxCpm8qRB4GND3CfBWCvhZs46PIFm+B/j1qRk=;20:v6J8WDRpNMpVJviiEpRVskqEqaSJ45QNXghZLhtdqAyEusxbaLBdmK8EvMQGyiTfkpH7GyIjTU2tCtJL1mCs3A== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB272; db4pr02mb272: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB4PR02MB272;BCL:0;PCL:0;RULEID:;SRVR:DB4PR02MB272; x-forefront-prvs: 06469BCC91 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(164054003)(377454003)(2950100001)(62966003)(189998001)(5002640100001)(122556002)(76576001)(74316001)(40100003)(92566002)(77096005)(93886004)(110136002)(77156002)(5003600100002)(5001960100002)(102836002)(86362001)(106116001)(2656002)(66066001)(2900100001)(87936001)(19580395003)(19580405001)(46102003)(54356999)(33656002)(76176999)(50986999);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR02MB272;H:DB4PR02MB272.eurprd02.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2015 10:40:36.6109 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB272 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6NAepdt020600 Content-Length: 532 Lines: 13 From: Peter Hurley [mailto:peter@hurleysoftware.com] Sent: Wednesday, July 22, 2015 3:52 PM > Subject: Re: [PATCH 4/4] serial: 8250_dw: use serial_in() and not readl() > From: Noam Camus > > This is now matches device endianness. > I'm not seeing where serial_in() is used here, as claimed by the $subject. Thanks, I will "reword" my commit in v2 ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?