Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753245AbbGWLTy (ORCPT ); Thu, 23 Jul 2015 07:19:54 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:49133 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945AbbGWLTt (ORCPT ); Thu, 23 Jul 2015 07:19:49 -0400 Message-ID: <55B0CDCA.5040902@tronnes.org> Date: Thu, 23 Jul 2015 13:19:38 +0200 From: =?windows-1252?Q?Noralf_Tr=F8nnes?= User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Greg KH , Fabio Falzoi CC: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/10] Staging: fbtft: Use a helper function to set set_addr_win op References: <1435646597-7612-1-git-send-email-fabio.falzoi84@gmail.com> <1435646597-7612-7-git-send-email-fabio.falzoi84@gmail.com> <20150715021423.GD4788@kroah.com> In-Reply-To: <20150715021423.GD4788@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 28 Den 15.07.2015 04:14, skrev Greg KH: > On Tue, Jun 30, 2015 at 08:43:13AM +0200, Fabio Falzoi wrote: >> Use a helper function to choose which set_addr_win implementation to >> use, based on the value of the setaddrwin module parameter. >> >> Signed-off-by: Fabio Falzoi >> --- >> drivers/staging/fbtft/flexfb.c | 47 +++++++++++++++++++++++++----------------- >> 1 file changed, 28 insertions(+), 19 deletions(-) > Again, why? > > I need a maintainer of the code to ack any of these... > I know this code fairly well, but I have to look up the details. Moving these details from the probe function into small functions makes it more difficult for me get to those details in a glance. I would now have to scroll back and forth to see how flexfb is doing things, especially since flexfb differs from the other drivers which uses common functions in fbtft-core.c. So I prefer to keep it as it is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/