From: Badola Nikhil <nikhil.badola@freescale.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH 3/3] arm: dts: ls1021a: Add snps,configure-gfladj property
 to USB3 node
Thread-Topic: [PATCH 3/3] arm: dts: ls1021a: Add snps,configure-gfladj
 property to USB3 node
Thread-Index: AQHQxSyY1k+bd+kr+keunSPJ2IciZZ3o1YcAgAAMqRA=
Date: Thu, 23 Jul 2015 11:26:19 +0000
Message-ID: <SN1PR0301MB16290E4A5E871BCAEC4E06FCF3820@SN1PR0301MB1629.namprd03.prod.outlook.com>
References: <1437646378-1910-1-git-send-email-nikhil.badola@freescale.com>
 <1564365.o2o69FAsZI@ws-stein>
In-Reply-To: <1564365.o2o69FAsZI@ws-stein>
Accept-Language: en-US
Content-Language: en-US
sn1pr0301mb1632: X-MS-Exchange-Organization-RulesExecuted
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2015 11:26:19.4390
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB1632
X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1567;2:CeD6I44N/4EqLeY04mnooVgPfIt6E45UV1Px6N8odYYC0jH1ukoBPZ08AwM9Wmpw;3:W6wA7kGd2liXdkHYhmAelFVmyDeCeSosl1sQqYVB1KCkMTFgMSp8kp/XsvM8FPNptXGXZpV7X/EEd60oUtx49QKEQWD7Hy/yra1c6o3zrfaF2ADRdpueDPjbVlMazDAL/iuZFAPOAJFPYkzjjpQf+A==;25:t0LJ7NQlF28Jk2Wb/7Sz1grvDxm2SwILWI58geYE2HPJR+rRYDdXGHCBUrUOgHNoKy8p9IDl8jV4Zaxsjngshs/2mizAggu5yCZimED9Pzy7pKOMjqPZXOLZIJ/3yQVB9URSpCTXCLh1RZ9HBDG8W1X8S/y0evwBu3t+QAet4EsU92zO5aG8DNMrMJ5mJ19TwZB92agll/0EWYf8OyKIFT2qu6D5g4iyWwk6fqdpn3LDSLGZkTIi5Ecko1b5oAlvSQrWoiIZd/4hvwOIfRwXXQ==
X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB1567;20:g89JITLvCunHFTyl+YestT/bl7iabe+323qfcBA2dwX5k0EiD1eN9heFxaJcJTSbTK+zCo/6Qq4aNSJvEOfsywIutBIxAu2MNmejBmRLbUXuTbcMmx0Gh13uKjfRpodPEiseouV4Ui5xVxNIbdR6KuzLsNgvDxTz9qGR9Rl6qisLQGErth4JAcJ3B47j5eCQd5GBXQhTuypRsa3+jSq7zu4dbedhjTEFSoVqsMdTxDSOLrkaeYeFBBZiMSfKQhngl+OI9VBz67XTHVMqmx3oraOHKc3+HCKKVzCwPV43TVFFi9QuLTzufv4sgo51lSBQXz0SLvV66cWRDI/WhB3dHkmGcYMn31R171/9e8GXPbWIIYz6DoqAkC53cnRWg7I/E9eOANyri828yz3VW23qPEnvJScoqlrsXSfvMvBGGLRgVYxQMpaR8X74rqEEo0Yz6Qr/mOB8ZmCdyuPEgnolcPaLvH8peeZE/yI64NkAN/fyaBhNbmAJgfuS4V5n8b6X2lWxuZyangm6QRYwAjfmsFOQQOmcYOFiEJTeD1hRhrOKvKyqqj6Tnd2FPrGAbnV5cSi70FYMH89Yh1xNprZCP+XS585lflCm6IgyBH46+Jc=;23:F+/lnhP6YK1MbeMM9vakfRAkd1ada0gbCOhtIeBXqoaMTR0pGR+flKOCtnJWt5uLkbilSRSLNpONO3/BX1+H+6K5tmUhul6rEfbYnlZtjSlE1KpqwGRhr3AVqobUz4rIqCMgUu/C7P0BuhOD4IgwO4pDmBqDiPuPaeP2kcVET2icvKMKJdiB3YknRiXWUUPCgO0ypk/NFiq1VWpz+e76a401PJf7ygB7uYLPALZx43k5FIObdUGjenJjfJjmjwEA
SN1PR0301MB1567: X-MS-Exchange-Organization-RulesExecuted
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2482
Lines: 69

> -----Original Message-----
> From: Alexander Stein [mailto:alexander.stein@systec-electronic.com]
> Sent: Thursday, July 23, 2015 3:41 PM
> To: Badola Nikhil-B46172
> Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 3/3] arm: dts: ls1021a: Add snps,configure-gfladj
> property to USB3 node
> 
> On Thursday 23 July 2015 15:42:58, Nikhil Badola wrote:
> > Add "snps,configure-gfladj" boolean property to USB3 node. This
> > property
>                       ^^^^^^
> This does not match...
> 
> > is used to determine if frame length adjustment is required
> >
> > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> > ---
> >  arch/arm/boot/dts/ls1021a.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index c70bb27..f03f842 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -404,6 +404,7 @@
> >  			reg = <0x0 0x3100000 0x0 0x10000>;
> >  			interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> >  			dr_mode = "host";
> > +			snps,configure-fladj = <0x20>;
>                              ^^^^^
> ...that. The same is for the subject. I guess these "gfladj" are just leftovers as
> patch 1 & 2 talk about "fladj"

Fladj stands for Frame Length ADJustment whereas the register used for this is gfladj.
Yes we intend to override fladj, hence using fladj in patch 1 and 2. I will remove gladj from 
subject and description.
Further, I will be changing the property to "snps,fladj-override" as suggested by Mark in patch 1
and send next patch version.
Please let me know if there are any other comments. 

> 
> Best regards,
> Alexander
> --
> Dipl.-Inf. Alexander Stein
> SYS TEC electronic GmbH
> alexander.stein@systec-electronic.com
> 
> Legal and Commercial Address:
> Am Windrad 2
> 08468 Heinsdorfergrund
> Germany
> 
> Office: +49 (0) 3765 38600-0
> Fax:    +49 (0) 3765 38600-4100
> 
> Managing Directors:
> 	Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt;
> 	Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp
> Commercial Registry:
> 	Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/