Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169AbbGWLas (ORCPT ); Thu, 23 Jul 2015 07:30:48 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:40847 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbbGWLaj (ORCPT ); Thu, 23 Jul 2015 07:30:39 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.54 with qID t6NBUUmw017214, This message is accepted by code: ctloc85258 From: Hayes Wang To: Oliver Neukum CC: nic_swsd , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH net 2/3] r8152: fix remote wakeup Thread-Topic: [PATCH net 2/3] r8152: fix remote wakeup Thread-Index: AQHQxRZQabcxEOvD0E+W2lhe4+Q4dJ3oM4MAgACXLjD//4lcAIAAkEHA Date: Thu, 23 Jul 2015 11:30:30 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2F3ACFE@RTITMBSV03.realtek.com.tw> References: <1394712342-15778-148-Taiwan-albertk@realtek.com> <1394712342-15778-150-Taiwan-albertk@realtek.com> <1437640258.4377.6.camel@suse.com> <0835B3720019904CB8F7AA43166CEEB2F3AC58@RTITMBSV03.realtek.com.tw> <1437647246.4377.33.camel@suse.com> In-Reply-To: <1437647246.4377.33.camel@suse.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.71.143] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6NBUqYX020829 Content-Length: 1123 Lines: 23 Oliver Neukum [mailto:oneukum@suse.com] [...] > If the device does not support remote wakeup and the driver enables it, runtime > power management will be switched off. > That is the current state and it means that devices which don't support remote > wakeup cannot do runtime power management at all. But the driver is correct. > > The only time a device that doesn't support remote wakeup can do runtime power > managent is when no packets can be received that is while the interface is down. If > you want to allow that you must not set needs_remote_wakeup in probe(), but you > must set it in open() because it is necessary for runtime power management as I > explained above. > > Sorry for the length of this mail, but I wanted to make sure I am absolutely clear > this time. Thanks for you explanation. I focus on the wrong point. You mean this would cause the problem for runtime suspend. I would rethink my method and correct it. Best Regards, Hayes ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?