Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752501AbbGWMPg (ORCPT ); Thu, 23 Jul 2015 08:15:36 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:48592 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127AbbGWMP0 (ORCPT ); Thu, 23 Jul 2015 08:15:26 -0400 Date: Thu, 23 Jul 2015 15:15:24 +0300 From: Dan Carpenter To: Ioan-Adrian Ratiu Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, mateusz.kulikowski@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192e: rtllib: fix macro style issue Message-ID: <20150723121524.GT5371@mwanda> References: <1437649173-24280-1-git-send-email-adi@adirat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437649173-24280-1-git-send-email-adi@adirat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 31 On Thu, Jul 23, 2015 at 01:59:33PM +0300, Ioan-Adrian Ratiu wrote: > Enclose defined macro in paranthesis to avoid checkpatch complaint > "ERROR: Macros with complex values should be enclosed in parentheses" > > Signed-off-by: Ioan-Adrian Ratiu > --- > drivers/staging/rtl8192e/rtllib_rx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c > index 54dfff6..5f1650c 100644 > --- a/drivers/staging/rtl8192e/rtllib_rx.c > +++ b/drivers/staging/rtl8192e/rtllib_rx.c > @@ -1744,7 +1744,7 @@ static int rtllib_parse_qos_info_param_IE(struct rtllib_device *ieee, > return rc; > } > > -#define MFIE_STRING(x) case MFIE_TYPE_ ##x: return #x > +#define MFIE_STRING(x) (case MFIE_TYPE_ ##x: return #x) > This will break the build. Be more careful. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/