Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526AbbGWM2p (ORCPT ); Thu, 23 Jul 2015 08:28:45 -0400 Received: from outbound-smtp03.blacknight.com ([81.17.249.16]:38289 "EHLO outbound-smtp03.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbbGWM2g (ORCPT ); Thu, 23 Jul 2015 08:28:36 -0400 Date: Thu, 23 Jul 2015 13:28:28 +0100 From: Mel Gorman To: David Rientjes Cc: Linux-MM , Johannes Weiner , Rik van Riel , Vlastimil Babka , Pintu Kumar , Xishi Qiu , Gioh Kim , LKML Subject: Re: [PATCH 03/10] mm, page_alloc: Remove unnecessary recalculations for dirty zone balancing Message-ID: <20150723122827.GB2660@techsingularity.net> References: <1437379219-9160-1-git-send-email-mgorman@suse.com> <1437379219-9160-4-git-send-email-mgorman@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1261 Lines: 37 On Tue, Jul 21, 2015 at 05:08:42PM -0700, David Rientjes wrote: > On Mon, 20 Jul 2015, Mel Gorman wrote: > > > From: Mel Gorman > > > > File-backed pages that will be immediately dirtied are balanced between > > zones but it's unnecessarily expensive. Move consider_zone_balanced into > > the alloc_context instead of checking bitmaps multiple times. > > > > Signed-off-by: Mel Gorman > > Acked-by: David Rientjes > Thanks. > consider_zone_dirty eliminates zones over their dirty limits and > zone_dirty_ok() returns true if zones are under their dirty limits, so the > naming of both are a little strange. You might consider changing them > while you're here. Yeah, that seems sensible. I named the struct field spread_dirty_page so the relevant check now looks like if (ac->spread_dirty_page && !zone_dirty_ok(zone)) Alternative suggestions welcome but I think this is more meaningful than consider_zone_dirty was. -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/