Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbbGWMqC (ORCPT ); Thu, 23 Jul 2015 08:46:02 -0400 Received: from mail-bl2on0146.outbound.protection.outlook.com ([65.55.169.146]:54298 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752280AbbGWMpy convert rfc822-to-8bit (ORCPT ); Thu, 23 Jul 2015 08:45:54 -0400 X-Greylist: delayed 76796 seconds by postgrey-1.27 at vger.kernel.org; Thu, 23 Jul 2015 08:45:53 EDT From: Liberman Igal To: Liberman Igal , "netdev@vger.kernel.org" CC: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Madalin-Cristian Bucur , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" , "ppc@mindchasers.com" Subject: RE: [v3, 5/9] fsl/fman: Add Frame Manager support Thread-Topic: [v3, 5/9] fsl/fman: Add Frame Manager support Thread-Index: AQHQxJLaqaQnC5AzlkydHHLD5LPF8Z3o/3QQ Date: Thu, 23 Jul 2015 12:45:50 +0000 Message-ID: References: <1437564138-16592-1-git-send-email-igal.liberman@freescale.com> In-Reply-To: <1437564138-16592-1-git-send-email-igal.liberman@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freescale.com; dkim=none (message not signed) header.d=none; x-originating-ip: [192.88.162.1] x-microsoft-exchange-diagnostics: 1;DM2PR03MB381;24:gKkJfyWmBOuOsnLQ1wzYzy6t6inzZue0zRZmDkOJY5QM2Vf7FjVCzbDnrnztt3hyezgXMQ5UFGKQ1BU1P2A2cAbIK+UqngyG2YqHjXcra+A=;20:Uue3H1Nw82q80dNdpyt7UkhLoWv1QCYKdVBdIF3gKISTqhG7W5XuPEC8Tq1A5Fu7zAtiyNsNtUc+5S9BUO+t7g== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB381; dm2pr03mb381: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DM2PR03MB381;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB381; x-forefront-prvs: 06469BCC91 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(46102003)(5001960100002)(5003600100002)(74316001)(33656002)(40100003)(2501003)(2900100001)(2950100001)(99286002)(5002640100001)(92566002)(189998001)(54356999)(106116001)(76176999)(87936001)(77096005)(76576001)(66066001)(86362001)(102836002)(50986999)(122556002)(62966003)(2656002)(77156002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR03MB381;H:DM2PR03MB383.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2015 12:45:50.5926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB381 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 37 Regards, Igal Liberman. > +static struct platform_driver fm_driver = { > + .driver = { > + .name = "fsl-fman", > + .of_match_table = fm_match, > + }, > + .probe = fm_probe, > +}; > + > +builtin_platform_driver(fm_driver); > + > +static int __init __cold fm_load(void) > +{ > + if (platform_driver_register(&fm_driver)) { > + pr_crit("platform_driver_register() failed\n"); > + return -ENODEV; > + } > + > + pr_info("Freescale FMan module\n"); > + return 0; > +} > + > +device_initcall(fm_load); Please notice, when using builtin_platform_driver, device_initcall(fm_load); becomes redundant. Same issue in 2 other places. I have patches which fix that which were left out of this submission, I'll add them to v4. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/