Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753233AbbGWNEB (ORCPT ); Thu, 23 Jul 2015 09:04:01 -0400 Received: from foss.arm.com ([217.140.101.70]:40252 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbbGWNDt (ORCPT ); Thu, 23 Jul 2015 09:03:49 -0400 Date: Thu, 23 Jul 2015 14:03:44 +0100 From: Catalin Marinas To: yalin wang Cc: will.deacon@arm.com, zlim.lnx@gmail.com, punit.agrawal@arm.com, marc.zyngier@arm.com, lauraa@codeaurora.org, wcohen@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] arm64:use set_fixmap_offset to make it more clear Message-ID: <20150723130344.GC27052@e104818-lin.cambridge.arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 32 On Thu, Jul 23, 2015 at 07:45:53PM +0800, yalin wang wrote: > A little change to patch_map() function, > use set_fixmap_offset() to make code more clear. > > Signed-off-by: yalin wang > --- > arch/arm64/kernel/insn.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > index dd9671c..7dafd5a 100644 > --- a/arch/arm64/kernel/insn.c > +++ b/arch/arm64/kernel/insn.c > @@ -101,9 +101,8 @@ static void __kprobes *patch_map(void *addr, int fixmap) > return addr; > > BUG_ON(!page); > - set_fixmap(fixmap, page_to_phys(page)); > - > - return (void *) (__fix_to_virt(fixmap) + (uintaddr & ~PAGE_MASK)); > + return (void *)set_fixmap_offset(fixmap, page_to_phys(page) + > + (addr & ~PAGE_MASK)); It looks fine. Do you get any compiler warning for the automatic pointer to long conversion? You may want to add some explicit casts, otherwise: Acked-by: Catalin Marinas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/