Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123AbbGWNGV (ORCPT ); Thu, 23 Jul 2015 09:06:21 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:34770 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752971AbbGWNFb (ORCPT ); Thu, 23 Jul 2015 09:05:31 -0400 Date: Thu, 23 Jul 2015 08:05:24 -0500 From: Bjorn Helgaas To: Marc Zyngier Cc: Thomas Gleixner , Jiang Liu , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yijing Wang , Ma Jun , Lorenzo Pieralisi , Duc Dang Subject: Re: [PATCH v5 02/19] PCI: MSI: Register irq domain with specific token Message-ID: <20150723130524.GQ21967@google.com> References: <1437643598-19795-1-git-send-email-marc.zyngier@arm.com> <1437643598-19795-3-git-send-email-marc.zyngier@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437643598-19795-3-git-send-email-marc.zyngier@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2051 Lines: 70 Nit: "PCI/MSI" in subject so it matches the rest. On Thu, Jul 23, 2015 at 10:26:21AM +0100, Marc Zyngier wrote: > When creating a PCI/MSI domain, tag it with DOMAIN_BUS_PCI_MSI so > that it can be looked-up using irq_find_matching_host(). > > Signed-off-by: Marc Zyngier Acked-by: Bjorn Helgaas > --- > drivers/pci/msi.c | 8 +++++++- > include/linux/irqdomain.h | 1 + > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c > index 373d96e..ef4ec6e 100644 > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -1273,12 +1273,18 @@ struct irq_domain *pci_msi_create_irq_domain(struct device_node *node, > struct msi_domain_info *info, > struct irq_domain *parent) > { > + struct irq_domain *domain; > + > if (info->flags & MSI_FLAG_USE_DEF_DOM_OPS) > pci_msi_domain_update_dom_ops(info); > if (info->flags & MSI_FLAG_USE_DEF_CHIP_OPS) > pci_msi_domain_update_chip_ops(info); > > - return msi_create_irq_domain(node, info, parent); > + domain = msi_create_irq_domain(node, info, parent); > + if (domain) > + domain->bus_token = DOMAIN_BUS_PCI_MSI; > + > + return domain; Nit2: I have a slight preference, hardly worth mentioning in such a simple case, for this: domain = msi_create_irq_domain(node, info, parent); if (!domain) return NULL; domain->bus_token = DOMAIN_BUS_PCI_MSI; return domain; > } > > /** > diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h > index 91a83ad..25e9e66 100644 > --- a/include/linux/irqdomain.h > +++ b/include/linux/irqdomain.h > @@ -54,6 +54,7 @@ struct irq_data; > */ > enum irq_domain_bus_token { > DOMAIN_BUS_ANY = 0, > + DOMAIN_BUS_PCI_MSI, > }; > > /** > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/