Date: Thu, 23 Jul 2015 06:58:42 -0700
From: =?utf-8?B?U8O2cmVu?= Brinkmann <soren.brinkmann@xilinx.com>
To: Suneel Garapati <suneel.garapati@xilinx.com>
CC: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@vger.kernel.org>,
        <michals@xilinx.com>, <sorenb@xilinx.com>,
        <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] devicetree: xilinx: add rtc node to zynqmp dtsi
Message-ID: <20150723135842.GG2531@xsjsorenbubuntu>
References: <1437648740-7587-1-git-send-email-suneel.garapati@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1437648740-7587-1-git-send-email-suneel.garapati@xilinx.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
BL2FFO11HUB040: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2015 13:58:49.2564
 (UTC)
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB040
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1601
Lines: 52

Hi Suneel,

On Thu, 2015-07-23 at 04:22PM +0530, Suneel Garapati wrote:
> adds rtc controller node to zynqmp devicetree.
> 
> Signed-off-by: Suneel Garapati <suneel.garapati@xilinx.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts | 4 ++++
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi      | 9 +++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> index 0a3f40e..b48ce47 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-ep108.dts
> @@ -45,3 +45,7 @@
>  &uart0 {
> 	status = "okay";
>  };
> +
> +&rtc {
> +	status = "okay";
> +};
> \ No newline at end of file
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 11e0b00..b76ede1 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -220,6 +220,15 @@
> 			#size-cells = <0>;
> 		};
> 
> +		rtc: rtc@ffa60000 {
> +			compatible = "xlnx,zynqmp-rtc";
> +			status = "disabled";

do we need the status disabled here?

> +			reg = <0x0 0xffa60000 0x100>;
> +			interrupt-parent = <&gic>;
> +			interrupts = <0 26 4>, <0 27 4>;
> +			interrupt-names = "alm", "sec";

Descriptive names would be nice. What is 'alm' supposed to mean?

	Thanks,
	Sören
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/