Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752717AbbGWOQc (ORCPT ); Thu, 23 Jul 2015 10:16:32 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36701 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501AbbGWOQZ (ORCPT ); Thu, 23 Jul 2015 10:16:25 -0400 MIME-Version: 1.0 In-Reply-To: References: <1437650286-117629-1-git-send-email-valentinrothberg@gmail.com> <20150723134714.GA29224@quack.suse.cz> From: Valentin Rothberg Date: Thu, 23 Jul 2015 16:15:55 +0200 Message-ID: Subject: Re: [PATCH] mm/Kconfig: NEED_BOUNCE_POOL: clean-up condition To: Jan Kara , Greg KH Cc: akpm@linux-foundation.org, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Paul Bolle , hengelein Stefan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3024 Lines: 76 On Thu, Jul 23, 2015 at 4:01 PM, Valentin Rothberg wrote: > Hi Jan, > > On Thu, Jul 23, 2015 at 3:47 PM, Jan Kara wrote: >> On Thu 23-07-15 13:18:06, Valentin Rothberg wrote: >>> commit 106542e7987c ("fs: Remove ext3 filesystem driver") removed ext3 >>> and JBD, hence remove the superfluous condition. >>> >>> Signed-off-by: Valentin Rothberg >>> --- >>> I detected the issue with undertaker-checkpatch >>> (https://undertaker.cs.fau.de) >> >> Thanks. I have added your patch into my tree. BTW, is the checker automated >> enough that it could be made part of the 0-day tests Fengguang runs? > > The checker is automated, but it also produces false positives for > certain kinds of bugs/defects, so we decided to run the bot on our > servers at the University of Erlangen-Nuremberg. It runs daily on > linux-next; we check the reports and fix the issue as above or we > report it to the authors and maintainers. So we catch things as soon > as they are in linux-next. > > If you want to check for symbolic issues (i.e., references on > undefined Kconfig opionts/symbols) you can use > scripts/checkkconfigsymbols.py which detects most of the cases. > However, this script did not catch the upper case (I will check why). checkkconfigsymbols.py did not detect the issue since it does not check (yet) default statements. I fixed it locally and will send a patch tomorrow after testing it on more Linux versions. Kind regards, Valentin > Kind regards, > Valentin > >> Honza >> >>> mm/Kconfig | 8 +------- >>> 1 file changed, 1 insertion(+), 7 deletions(-) >>> >>> diff --git a/mm/Kconfig b/mm/Kconfig >>> index e79de2bd12cd..d4e6495a720f 100644 >>> --- a/mm/Kconfig >>> +++ b/mm/Kconfig >>> @@ -299,15 +299,9 @@ config BOUNCE >>> # On the 'tile' arch, USB OHCI needs the bounce pool since tilegx will often >>> # have more than 4GB of memory, but we don't currently use the IOTLB to present >>> # a 32-bit address to OHCI. So we need to use a bounce pool instead. >>> -# >>> -# We also use the bounce pool to provide stable page writes for jbd. jbd >>> -# initiates buffer writeback without locking the page or setting PG_writeback, >>> -# and fixing that behavior (a second time; jbd2 doesn't have this problem) is >>> -# a major rework effort. Instead, use the bounce buffer to snapshot pages >>> -# (until jbd goes away). The only jbd user is ext3. >>> config NEED_BOUNCE_POOL >>> bool >>> - default y if (TILE && USB_OHCI_HCD) || (BLK_DEV_INTEGRITY && JBD) >>> + default y if TILE && USB_OHCI_HCD >>> >>> config NR_QUICK >>> int >>> -- >>> 1.9.1 >>> >> -- >> Jan Kara >> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/