Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753610AbbGWOfK (ORCPT ); Thu, 23 Jul 2015 10:35:10 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:43228 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501AbbGWOfD (ORCPT ); Thu, 23 Jul 2015 10:35:03 -0400 Date: Thu, 23 Jul 2015 09:34:56 -0500 From: Felipe Balbi To: Badola Nikhil CC: Mark Rutland , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "balbi@ti.com" Subject: Re: [PATCH 1/3] Documentation: dt: dwc3: Add snps,configure-fladj property Message-ID: <20150723143456.GA21984@saruman.tx.rr.com> Reply-To: References: <1437646161-1764-1-git-send-email-nikhil.badola@freescale.com> <20150723095635.GA12330@leverpostej> <20150723105729.GB12330@leverpostej> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4691 Lines: 118 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 23, 2015 at 11:07:09AM +0000, Badola Nikhil wrote: > > -----Original Message----- > > From: Mark Rutland [mailto:mark.rutland@arm.com] > > Sent: Thursday, July 23, 2015 4:27 PM > > To: Badola Nikhil-B46172 > > Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; balbi@ti.= com > > Subject: Re: [PATCH 1/3] Documentation: dt: dwc3: Add snps,configure-fl= adj > > property > >=20 > > On Thu, Jul 23, 2015 at 11:52:19AM +0100, Badola Nikhil wrote: > > > > -----Original Message----- > > > > From: Mark Rutland [mailto:mark.rutland@arm.com] > > > > Sent: Thursday, July 23, 2015 3:27 PM > > > > To: Badola Nikhil-B46172 > > > > Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > balbi@ti.com > > > > Subject: Re: [PATCH 1/3] Documentation: dt: dwc3: Add > > > > snps,configure-fladj property > > > > > > > > On Thu, Jul 23, 2015 at 11:09:21AM +0100, Nikhil Badola wrote: > > > > > Add property snps,configure-fladj for enabling post silicon frame > > > > > length adjustment > > > > > > > > > > Signed-off-by: Nikhil Badola > > > > > --- > > > > > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt > > > > > b/Documentation/devicetree/bindings/usb/dwc3.txt > > > > > index 0815eac..90c3972 100644 > > > > > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > > > > > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > > > > > @@ -40,6 +40,7 @@ Optional properties: > > > > > - snps,hird-threshold: HIRD threshold > > > > > - snps,hsphy_interface: High-Speed PHY interface selection > > > > > between > > > > "utmi" for > > > > > UTMI+ and "ulpi" for ULPI when the DWC_USB3_HSPHY_INTERFACE > > > > > has > > > > value 3. > > > > > + - snps,configure-fladj: enables post-silicon frame length > > > > > + adjustment > > > > > > > > Could you elaborate on what this means and why you think it's > > necessary? > > > > > > This property enables the use of GFLADJ_30MHZ field value of gfladj > > > register for frame length adjustment instead of considering from the > > sideband input signal fladj_30mhz_reg from SOC. > > > This is required when signal fladj_30mhz_reg is connected to a wrong > > > value or is not valid as in our case, hence post-silicon. > >=20 > > Ok, so this is basically an override for the GFLADJ_30MHZ field of the = gfladj > > register when there was a problem at integration time. > > >=20 > That's right.=20 > =20 > > > However this field can be used to adjust any offset ranging from 00h > > > to 3Fh, from the clock source generating SOF(start of frame) packets. > > > Thus, this property can be added to device tree with appropriate > > adjustment value. > >=20 > > It takes a value? The description above makes it sound like a boolean > > property. > >=20 > > I'd expect a description more like: > >=20 > > - snps,fladj-override: Value for GFLADJ_30MHZ when the fladj_30mhz_reg > > signal is invalid or incorrect. > >=20 > > Which makes it clear what the value is and when it should be set. >=20 > Agreed. Will change and send a new version of the patch-set. BTW, I'm not going to accept this without a glue layer making use of it. Also, this patch needs to go to linux-usb as well, please resend. --=20 balbi --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVsPuQAAoJEIaOsuA1yqRE14wP/RXDFJ0FshI8eOpMzaIlc4r5 M+RLTyMHVM2d8Oova5R9TQSr4FNVTEFIeDHN3zthQn4wTrIREzlGc4+upLwww5Fa PwFySd9u3SG+OmWC/ENI8c4mWi6Au9N4Ea5jqBYnpmPvP1VJyPZczgKRtRhGhmZv pV+MKpPNFou3rDstNpLQ0gp9mRJUZKwjk7IyyoyQdLnja8gyN4qTisS5LyJHllWm fw0rrHuC2DNdNSPz2JUO9fVqZF2Y9t7WvH5GAQ8ZKLCg6gOSkzsShmM2LkROVM0W O6M3yfL1N8Eeh2QVhgmisxavXn4pzLboJR925t2PXVSY6qbYIimVHk8UK+YkmaR+ IQtCe2U8ExrC7PeOq8hsqLP98q36IaoMLaVZ+JyUD41UtfKtOKjT1ODrJQjEhAoG txazP3c73teqJq3fcxuyPNm84EK1dqHNc8ivNbopusJTFb0f281SKmuoKl8teB0f G5/cfYpDeBHxM5h2m5SDr2Pj8QdhP0ditkVxU9bTuJAuA3abT5nRKxu3GvyMui5Y JH9u/CJO0Gxg4i2F67LpvtgPmvtH1Vdg8F72mVGcTHw9Y1afDiCuNbw1qIINC4Gm 8cmo3ZiPSaLOQoL/fB0GrG66YjP5rYEF7DgiPW3Co7YZHctFrGHWpEBkIdg67S4A Z9PxoTSLOAsMod9kzyEs =kCVR -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/