Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753823AbbGWOpb (ORCPT ); Thu, 23 Jul 2015 10:45:31 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35145 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753644AbbGWOpW (ORCPT ); Thu, 23 Jul 2015 10:45:22 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 23 Jul 2015 16:45:21 +0200 Message-ID: Subject: Re: Fix one source file coding sytle issue. From: Frans Klaver To: "Incarnation P. Lee" Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, Greg KH , Julia Lawall , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1005 Lines: 32 Hi, On Thu, Jul 23, 2015 at 8:20 AM, Incarnation P. Lee wrote: > drivers/staging/lustre/lustre/obdclass/cl_page.c It is custom that you write slightly more introductory text here. Just a file name is pointless. The subject should probably contain [PATCH 0/5]. This would be automatically fixed for you when using 'git format-patch --cover-letter ...'. The other patches should at least mention the area of the kernel the change is done in: [PATCH N/5] staging: lustre: fix a missing space after comma So that it becomes immediately clear where the change is done, and what it is supposed to achieve. > Signed-off-by: Incarnation P. Lee That's not necessary in the cover letter. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/