Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539AbbGWOwx (ORCPT ); Thu, 23 Jul 2015 10:52:53 -0400 Received: from foss.arm.com ([217.140.101.70]:40732 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753069AbbGWOwo (ORCPT ); Thu, 23 Jul 2015 10:52:44 -0400 Message-ID: <55B0FFB8.3030506@arm.com> Date: Thu, 23 Jul 2015 15:52:40 +0100 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Bjorn Helgaas CC: Thomas Gleixner , Jiang Liu , Jason Cooper , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yijing Wang , Ma Jun , Lorenzo Pieralisi , Duc Dang Subject: Re: [PATCH v5 04/19] PCI/MSI: Add hooks to populate the msi_domain field References: <1437643598-19795-1-git-send-email-marc.zyngier@arm.com> <1437643598-19795-5-git-send-email-marc.zyngier@arm.com> <20150723130637.GR21967@google.com> In-Reply-To: <20150723130637.GR21967@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 42 On 23/07/15 14:06, Bjorn Helgaas wrote: > On Thu, Jul 23, 2015 at 10:26:23AM +0100, Marc Zyngier wrote: >> In order to be able to populate the device msi_domain field, >> add the necessary hooks to propagate the host bridge msi_domain >> across secondary busses to devices. >> >> So far, nobody populates the initial msi_domain. >> >> Signed-off-by: Marc Zyngier > > Acked-by: Bjorn Helgaas > >> +static void pci_set_msi_domain(struct pci_dev *dev) >> +{ >> + /* >> + * If no domain has been set through the pcibios callback, >> + * inherit the default from the bus device. > > Nit: there isn't a pcibios callback anymore. There is actually one, in pci_add_device: [...] ret = pcibios_add_device(dev); WARN_ON(ret < 0); /* Setup MSI irq domain */ pci_set_msi_domain(dev); [...] pcibios_add_device is the one I was referring to. I'll clarify the comment. Thanks, M. -- Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/