Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753373AbbGWPSo (ORCPT ); Thu, 23 Jul 2015 11:18:44 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36741 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753195AbbGWPSe (ORCPT ); Thu, 23 Jul 2015 11:18:34 -0400 Date: Thu, 23 Jul 2015 16:18:30 +0100 From: Lee Jones To: Richard Fitzgerald Cc: patches@opensource.wolfsonmicro.com, sameo@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] mfd: arizona: Specify regmap endianness Message-ID: <20150723151830.GL3436@x1> References: <1437407627-9894-1-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1437407627-9894-1-git-send-email-rf@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3589 Lines: 96 On Mon, 20 Jul 2015, Richard Fitzgerald wrote: > Explicitly set the regmap endianness instead of relying on > the default being correct. > > Signed-off-by: Richard Fitzgerald > --- > drivers/mfd/wm5102-tables.c | 4 ++++ > drivers/mfd/wm5110-tables.c | 4 ++++ > drivers/mfd/wm8997-tables.c | 2 ++ > drivers/mfd/wm8998-tables.c | 2 ++ > 4 files changed, 12 insertions(+), 0 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c > index aeae6ec..3981123 100644 > --- a/drivers/mfd/wm5102-tables.c > +++ b/drivers/mfd/wm5102-tables.c > @@ -1969,6 +1969,8 @@ const struct regmap_config wm5102_spi_regmap = { > .reg_bits = 32, > .pad_bits = 16, > .val_bits = 16, > + .reg_format_endian = REGMAP_ENDIAN_BIG, > + .val_format_endian = REGMAP_ENDIAN_BIG, > > .max_register = WM5102_MAX_REGISTER, > .readable_reg = wm5102_readable_register, > @@ -1983,6 +1985,8 @@ EXPORT_SYMBOL_GPL(wm5102_spi_regmap); > const struct regmap_config wm5102_i2c_regmap = { > .reg_bits = 32, > .val_bits = 16, > + .reg_format_endian = REGMAP_ENDIAN_BIG, > + .val_format_endian = REGMAP_ENDIAN_BIG, > > .max_register = WM5102_MAX_REGISTER, > .readable_reg = wm5102_readable_register, > diff --git a/drivers/mfd/wm5110-tables.c b/drivers/mfd/wm5110-tables.c > index 12cad94..e92b1c8 100644 > --- a/drivers/mfd/wm5110-tables.c > +++ b/drivers/mfd/wm5110-tables.c > @@ -3007,6 +3007,8 @@ const struct regmap_config wm5110_spi_regmap = { > .reg_bits = 32, > .pad_bits = 16, > .val_bits = 16, > + .reg_format_endian = REGMAP_ENDIAN_BIG, > + .val_format_endian = REGMAP_ENDIAN_BIG, > > .max_register = WM5110_MAX_REGISTER, > .readable_reg = wm5110_readable_register, > @@ -3021,6 +3023,8 @@ EXPORT_SYMBOL_GPL(wm5110_spi_regmap); > const struct regmap_config wm5110_i2c_regmap = { > .reg_bits = 32, > .val_bits = 16, > + .reg_format_endian = REGMAP_ENDIAN_BIG, > + .val_format_endian = REGMAP_ENDIAN_BIG, > > .max_register = WM5110_MAX_REGISTER, > .readable_reg = wm5110_readable_register, > diff --git a/drivers/mfd/wm8997-tables.c b/drivers/mfd/wm8997-tables.c > index c0c25d75..01bb57b 100644 > --- a/drivers/mfd/wm8997-tables.c > +++ b/drivers/mfd/wm8997-tables.c > @@ -1521,6 +1521,8 @@ static bool wm8997_volatile_register(struct device *dev, unsigned int reg) > const struct regmap_config wm8997_i2c_regmap = { > .reg_bits = 32, > .val_bits = 16, > + .reg_format_endian = REGMAP_ENDIAN_BIG, > + .val_format_endian = REGMAP_ENDIAN_BIG, > > .max_register = WM8997_MAX_REGISTER, > .readable_reg = wm8997_readable_register, > diff --git a/drivers/mfd/wm8998-tables.c b/drivers/mfd/wm8998-tables.c > index 60e8622..e6de3cd 100644 > --- a/drivers/mfd/wm8998-tables.c > +++ b/drivers/mfd/wm8998-tables.c > @@ -1580,6 +1580,8 @@ static bool wm8998_volatile_register(struct device *dev, unsigned int reg) > const struct regmap_config wm8998_i2c_regmap = { > .reg_bits = 32, > .val_bits = 16, > + .reg_format_endian = REGMAP_ENDIAN_BIG, > + .val_format_endian = REGMAP_ENDIAN_BIG, > > .max_register = WM8998_MAX_REGISTER, > .readable_reg = wm8998_readable_register, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/