Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbbGWPgt (ORCPT ); Thu, 23 Jul 2015 11:36:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53803 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753780AbbGWPgk (ORCPT ); Thu, 23 Jul 2015 11:36:40 -0400 Subject: Re: [RFC] arm64:use set_fixmap_offset to make it more clear To: yalin wang , catalin.marinas@arm.com, will.deacon@arm.com, zlim.lnx@gmail.com, punit.agrawal@arm.com, marc.zyngier@arm.com, lauraa@codeaurora.org, wcohen@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Laura Abbott Message-ID: <55B1084A.5020303@redhat.com> Date: Thu, 23 Jul 2015 08:29:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 33 On 07/23/2015 04:45 AM, yalin wang wrote: > A little change to patch_map() function, > use set_fixmap_offset() to make code more clear. > > Signed-off-by: yalin wang > --- > arch/arm64/kernel/insn.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c > index dd9671c..7dafd5a 100644 > --- a/arch/arm64/kernel/insn.c > +++ b/arch/arm64/kernel/insn.c > @@ -101,9 +101,8 @@ static void __kprobes *patch_map(void *addr, int fixmap) > return addr; > > BUG_ON(!page); > - set_fixmap(fixmap, page_to_phys(page)); > - > - return (void *) (__fix_to_virt(fixmap) + (uintaddr & ~PAGE_MASK)); > + return (void *)set_fixmap_offset(fixmap, page_to_phys(page) + > + (addr & ~PAGE_MASK)); > } > > static void __kprobes patch_unmap(int fixmap) > Reviewed-by: Laura Abbott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/