Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbbGWPhW (ORCPT ); Thu, 23 Jul 2015 11:37:22 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36591 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752915AbbGWPhP (ORCPT ); Thu, 23 Jul 2015 11:37:15 -0400 MIME-Version: 1.0 In-Reply-To: <55B0FFB8.3030506@arm.com> References: <1437643598-19795-1-git-send-email-marc.zyngier@arm.com> <1437643598-19795-5-git-send-email-marc.zyngier@arm.com> <20150723130637.GR21967@google.com> <55B0FFB8.3030506@arm.com> From: Bjorn Helgaas Date: Thu, 23 Jul 2015 10:36:54 -0500 Message-ID: Subject: Re: [PATCH v5 04/19] PCI/MSI: Add hooks to populate the msi_domain field To: Marc Zyngier Cc: Thomas Gleixner , Jiang Liu , Jason Cooper , "linux-arm-kernel@lists.infradead.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yijing Wang , Ma Jun , Lorenzo Pieralisi , Duc Dang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 41 On Thu, Jul 23, 2015 at 9:52 AM, Marc Zyngier wrote: > On 23/07/15 14:06, Bjorn Helgaas wrote: >> On Thu, Jul 23, 2015 at 10:26:23AM +0100, Marc Zyngier wrote: >>> In order to be able to populate the device msi_domain field, >>> add the necessary hooks to propagate the host bridge msi_domain >>> across secondary busses to devices. >>> >>> So far, nobody populates the initial msi_domain. >>> >>> Signed-off-by: Marc Zyngier >> >> Acked-by: Bjorn Helgaas >> >>> +static void pci_set_msi_domain(struct pci_dev *dev) >>> +{ >>> + /* >>> + * If no domain has been set through the pcibios callback, >>> + * inherit the default from the bus device. >> >> Nit: there isn't a pcibios callback anymore. > > There is actually one, in pci_add_device: > > [...] > ret = pcibios_add_device(dev); > WARN_ON(ret < 0); > > /* Setup MSI irq domain */ > pci_set_msi_domain(dev); > [...] > > pcibios_add_device is the one I was referring to. I'll clarify the comment. Oh, right! I thought you were referring to pcibios_set_host_bridge_msi_domain(), which got removed, but of course that wouldn't even make sense. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/