Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565AbbGWPra (ORCPT ); Thu, 23 Jul 2015 11:47:30 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:44961 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbbGWPrV (ORCPT ); Thu, 23 Jul 2015 11:47:21 -0400 X-Sender-Id: abbotti@mev.co.uk From: Ian Abbott To: Cc: Greg Kroah-Hartman , Ian Abbott , H Hartley Sweeten , Bernd Porr , Subject: [PATCH 0/6] staging: comedi: usbduxsigma: fix some problems in command handling Date: Thu, 23 Jul 2015 16:46:56 +0100 Message-Id: <1437666422-25222-1-git-send-email-abbotti@mev.co.uk> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 24 Fix some minor problems in the testing of asynchronous commands for the AI and AO subdevices and remove some redundant code. The main problem is that the testing of a new command can affect the operation of an already running command, which it isn't supposed to do. (In practice, applications don't tend to test new commands while a command is running on the same subdevice, so the bug can be classed as minor.) This is corrected by the patches 1 and 2, for the AI and AO subdevices, respectively. 1) staging: comedi: usbduxsigma: don't clobber ai_timer in command test 2) staging: comedi: usbduxsigma: don't clobber ao_timer in command test 3) staging: comedi: usbduxsigma: remove AI scan_begin_src == TRIG_FOLLOW 4) staging: comedi: usbduxsigma: round down AI scan_begin_arg at step 4. 5) staging: comedi: usbduxsigma: remove unused "convert" timing for AO 6) staging: comedi: usbduxsigma: round down AO scan_begin_arg at step 4. drivers/staging/comedi/drivers/usbduxsigma.c | 139 +++++++++++---------------- 1 file changed, 54 insertions(+), 85 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/