Date: Thu, 23 Jul 2015 12:01:25 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>, linux-kernel@vger.kernel.org,
        Willy Tarreau <w@1wt.eu>, Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/5] x86/entry/64, entry: Set up a valid sysenter stack
 and prepare for 32-bit merge
Message-ID: <20150723120125.7c6d74d3@gandalf.local.home>
In-Reply-To: <1287f683e32f1bbe7fc545bff675f30dcda8d5c1.1437665045.git.luto@kernel.org>
References: <cover.1437665045.git.luto@kernel.org>
	<1287f683e32f1bbe7fc545bff675f30dcda8d5c1.1437665045.git.luto@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 994
Lines: 26

On Thu, 23 Jul 2015 08:31:40 -0700
Andy Lutomirski <luto@kernel.org> wrote:

> Oddly, 64-bit kernels already allocate a percpu sysenter stack, but
> they don't enable it.  Enable the stack and tweak the rest of the
> sysenter setup code to be similar to the 32-bit version.

I'm curious. Did you do any investigation into the 64bit code to why it
wasn't set? Do you know if that was just overlooked with some of the
merging between i386 and x86_64 systems?

I'm not asking you to do it if you have not, but if you have, I think
it would be more comforting to know that it was just overlooked than
there being some other subtle reason.

-- Steve

> 
> This eliminates the only place in the kernel in which TF could be set
> without a valid stack.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/