Date: Thu, 23 Jul 2015 12:10:01 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Willy Tarreau <w@1wt.eu>, Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 2/5] x86/entry/64, entry: Set up a valid sysenter stack
 and prepare for 32-bit merge
Message-ID: <20150723121001.2d7d8812@gandalf.local.home>
In-Reply-To: <CALCETrVi3Np9_pXWbMfFJO4Qt+M3yio4gMgz1H6q2hHQ5zpZuA@mail.gmail.com>
References: <cover.1437665045.git.luto@kernel.org>
	<1287f683e32f1bbe7fc545bff675f30dcda8d5c1.1437665045.git.luto@kernel.org>
	<20150723120125.7c6d74d3@gandalf.local.home>
	<CALCETrVi3Np9_pXWbMfFJO4Qt+M3yio4gMgz1H6q2hHQ5zpZuA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1436
Lines: 33

On Thu, 23 Jul 2015 09:04:38 -0700
Andy Lutomirski <luto@amacapital.net> wrote:

> On Thu, Jul 23, 2015 at 9:01 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Thu, 23 Jul 2015 08:31:40 -0700
> > Andy Lutomirski <luto@kernel.org> wrote:
> >
> >> Oddly, 64-bit kernels already allocate a percpu sysenter stack, but
> >> they don't enable it.  Enable the stack and tweak the rest of the
> >> sysenter setup code to be similar to the 32-bit version.
> >
> > I'm curious. Did you do any investigation into the 64bit code to why it
> > wasn't set? Do you know if that was just overlooked with some of the
> > merging between i386 and x86_64 systems?
> >
> > I'm not asking you to do it if you have not, but if you have, I think
> > it would be more comforting to know that it was just overlooked than
> > there being some other subtle reason.
> 
> I think it's just that it was never necessary.  #DB has always used
> IST on x86_64 (IIRC it was like that in the very first commit), so the
> sysenter stack was never actually referenced.
> 

Hmm, should this be commented? If it is never referenced, I could
imagine that would add some confusion to future reviewers of this code.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/