Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753906AbbGWRCD (ORCPT <rfc822;w@1wt.eu>);
	Thu, 23 Jul 2015 13:02:03 -0400
Received: from bear.ext.ti.com ([192.94.94.41]:47632 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752923AbbGWRCA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 23 Jul 2015 13:02:00 -0400
Message-ID: <55B11DE2.3030502@ti.com>
Date: Thu, 23 Jul 2015 12:01:22 -0500
From: Andreas Dannenberg <dannenberg@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= <pali.rohar@gmail.com>,
        "Andrew F. Davis" <afd@ti.com>
CC: Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>, Dan Murphy <dmurphy@ti.com>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/8] Add support for additional bq27xxx devices
References: <1437601920-13045-1-git-send-email-afd@ti.com> <20150723162748.GJ29125@pali>
In-Reply-To: <20150723162748.GJ29125@pali>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1652
Lines: 44

On 07/23/2015 11:27 AM, Pali Rohár wrote:
> On Wednesday 22 July 2015 16:51:52 Andrew F. Davis wrote:

<snip>

> And I have another question for you: I see that there are now more
> bq24*_charger.c drivers for TI BQ charger chips. Do you think if it is
> possible to do some cleanup & merge? Or all those charger chips
> different and every one should live in own kernel module?
 
Pali,
on a related note I recently started working on a new driver named
bq242xx_charger.c that will add support for the following devices:

bq24250
bq24251
bq24261M
bq24262

These are TI's key devices in the bq2425x and bq2426x sub-families. I was
actually also thinking about some larger consolidation but was
concerned about touching/breaking existing stuff and decided to do one
step at a time. And yes while there is some system-level overlap between
most bq24xxx I'm also worried that providing good coverage of all
important device features for all different bq24xxx devices would yield
a very large and hard to understand driver.

As part of the bq242xx_charger.c development I'm keeping a close eye on
the existing bq24xxx drivers. If there seems an elegant way to do some
consolidation after all I might be able to broaden the scope of my work.

This being said I welcome additional ideas/suggestions here but for this
we should probably start a new thread.

Regards,

-- 
Andreas Dannenberg
Texas Instruments Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/