Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754352AbbGWRTC (ORCPT ); Thu, 23 Jul 2015 13:19:02 -0400 Received: from smtp.citrix.com ([66.165.176.89]:44820 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810AbbGWRS7 (ORCPT ); Thu, 23 Jul 2015 13:18:59 -0400 X-IronPort-AV: E=Sophos;i="5.15,532,1432598400"; d="scan'208";a="283793137" Message-ID: <55B121D0.8070507@citrix.com> Date: Thu, 23 Jul 2015 18:18:08 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Stefano Stabellini CC: , Konrad Rzeszutek Wilk , , David Vrabel , , Boris Ostrovsky , , =?windows-1252?Q?Roger_Pau_Mon?= =?windows-1252?Q?n=E9?= Subject: Re: [PATCH v2 06/20] block/xen-blkfront: Store a page rather a pfn in the grant structure References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-7-git-send-email-julien.grall@citrix.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2532 Lines: 83 Hi Stefano, On 16/07/15 16:11, Stefano Stabellini wrote: > On Thu, 9 Jul 2015, Julien Grall wrote: >> All the usage of the field pfn are done using the same idiom: >> >> pfn_to_page(grant->pfn) >> >> This will return always the same page. Store directly the page in the >> grant to clean up the code. >> >> Signed-off-by: Julien Grall >> Cc: Konrad Rzeszutek Wilk >> Cc: Roger Pau Monn? >> Cc: Boris Ostrovsky >> Cc: David Vrabel >> --- >> Changes in v2: >> - Patch added >> --- >> drivers/block/xen-blkfront.c | 37 ++++++++++++++++++------------------- >> 1 file changed, 18 insertions(+), 19 deletions(-) >> >> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c >> index 7107d58..7b81d23 100644 >> --- a/drivers/block/xen-blkfront.c >> +++ b/drivers/block/xen-blkfront.c >> @@ -67,7 +67,7 @@ enum blkif_state { >> >> struct grant { >> grant_ref_t gref; >> - unsigned long pfn; >> + struct page *page; >> struct list_head node; >> }; >> >> @@ -219,7 +219,7 @@ static int fill_grant_buffer(struct blkfront_info *info, int num) >> kfree(gnt_list_entry); >> goto out_of_memory; >> } >> - gnt_list_entry->pfn = page_to_pfn(granted_page); >> + gnt_list_entry->page = granted_page; >> } >> >> gnt_list_entry->gref = GRANT_INVALID_REF; >> @@ -234,7 +234,7 @@ out_of_memory: >> &info->grants, node) { >> list_del(&gnt_list_entry->node); >> if (info->feature_persistent) >> - __free_page(pfn_to_page(gnt_list_entry->pfn)); >> + __free_page(gnt_list_entry->page); >> kfree(gnt_list_entry); >> i--; >> } >> @@ -243,7 +243,7 @@ out_of_memory: >> } >> >> static struct grant *get_grant(grant_ref_t *gref_head, >> - unsigned long pfn, >> + struct page *page, >> struct blkfront_info *info) > > indentation The indentation of the parameters wasn't valid. I will indent correctly "struct blkfront_info *info" rather than to use invalid indent. > Aside from this: > > Reviewed-by: Stefano Stabellini Thank you, Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/