Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754253AbbGWRhL (ORCPT ); Thu, 23 Jul 2015 13:37:11 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:37545 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753979AbbGWRhG (ORCPT ); Thu, 23 Jul 2015 13:37:06 -0400 From: Matthias Brugger To: Eddie Huang Cc: Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Sascha Hauer , Greta Zhang Subject: Re: [PATCH v2 2/2] watchdog: add wdt shutdown callback to disable wdt if enabled Date: Thu, 23 Jul 2015 19:37:03 +0200 Message-ID: <1488521.5eJqASov2O@ubix> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1437630551-39650-3-git-send-email-eddie.huang@mediatek.com> References: <1437630551-39650-1-git-send-email-eddie.huang@mediatek.com> <1437630551-39650-3-git-send-email-eddie.huang@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 20 On Thursday, July 23, 2015 01:49:11 PM Eddie Huang wrote: > From: Greta Zhang > > Without .shutdown(), watchdog might reset the system during power off. > For example, if watchdog's timeout is set to 30s, then it is reset to > zero by mtk_wdt_ping(). During power off, no app will ping watchdog, > but watchdog is still running and may trigger reset. > > Signed-off-by: Greta Zhang > Signed-off-by: Eddie Huang > --- > drivers/watchdog/mtk_wdt.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Acked-by: Matthias Brugger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/