Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753977AbbGWSeR (ORCPT ); Thu, 23 Jul 2015 14:34:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:34697 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753401AbbGWSeO (ORCPT ); Thu, 23 Jul 2015 14:34:14 -0400 Subject: Re: [PATCH] mm, page_isolation: make set/unset_migratetype_isolate() file-local To: Naoya Horiguchi , Andrew Morton References: <1437630002-25936-1-git-send-email-n-horiguchi@ah.jp.nec.com> Cc: David Rientjes , Joonsoo Kim , Minchan Kim , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" From: Vlastimil Babka Message-ID: <55B133A1.3050403@suse.cz> Date: Thu, 23 Jul 2015 20:34:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1437630002-25936-1-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2304 Lines: 59 On 07/23/2015 07:40 AM, Naoya Horiguchi wrote: > Nowaday, set/unset_migratetype_isolate() is defined and used only in > mm/page_isolation, so let's limit the scope within the file. > > Signed-off-by: Naoya Horiguchi Acked-by: Vlastimil Babka > --- > include/linux/page-isolation.h | 5 ----- > mm/page_isolation.c | 5 +++-- > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git v4.2-rc2.orig/include/linux/page-isolation.h v4.2-rc2/include/linux/page-isolation.h > index 2dc1e1697b45..047d64706f2a 100644 > --- v4.2-rc2.orig/include/linux/page-isolation.h > +++ v4.2-rc2/include/linux/page-isolation.h > @@ -65,11 +65,6 @@ undo_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, > bool skip_hwpoisoned_pages); > > -/* > - * Internal functions. Changes pageblock's migrate type. > - */ > -int set_migratetype_isolate(struct page *page, bool skip_hwpoisoned_pages); > -void unset_migratetype_isolate(struct page *page, unsigned migratetype); > struct page *alloc_migrate_target(struct page *page, unsigned long private, > int **resultp); > > diff --git v4.2-rc2.orig/mm/page_isolation.c v4.2-rc2/mm/page_isolation.c > index 32fdc1df05e5..4568fd58f70a 100644 > --- v4.2-rc2.orig/mm/page_isolation.c > +++ v4.2-rc2/mm/page_isolation.c > @@ -9,7 +9,8 @@ > #include > #include "internal.h" > > -int set_migratetype_isolate(struct page *page, bool skip_hwpoisoned_pages) > +static int set_migratetype_isolate(struct page *page, > + bool skip_hwpoisoned_pages) > { > struct zone *zone; > unsigned long flags, pfn; > @@ -72,7 +73,7 @@ int set_migratetype_isolate(struct page *page, bool skip_hwpoisoned_pages) > return ret; > } > > -void unset_migratetype_isolate(struct page *page, unsigned migratetype) > +static void unset_migratetype_isolate(struct page *page, unsigned migratetype) > { > struct zone *zone; > unsigned long flags, nr_pages; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/