Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbbGXFn3 (ORCPT ); Fri, 24 Jul 2015 01:43:29 -0400 Received: from mailgw02.mediatek.com ([218.249.47.111]:53357 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751336AbbGXFn0 (ORCPT ); Fri, 24 Jul 2015 01:43:26 -0400 X-Listener-Flag: 11101 Message-ID: <1437716593.23932.73.camel@mhfsdcap03> Subject: Re: [PATCH v3 5/6] iommu/mediatek: Add mt8173 IOMMU driver From: Yong Wu To: Will Deacon CC: Joerg Roedel , Thierry Reding , Mark Rutland , Matthias Brugger , Robin Murphy , Daniel Kurtz , Tomasz Figa , Lucas Stach , Rob Herring , Catalin Marinas , "linux-mediatek@lists.infradead.org" , Sasha Hauer , "srv_heupstream@mediatek.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "iommu@lists.linux-foundation.org" , "pebolle@tiscali.nl" , "arnd@arndb.de" , "mitchelh@codeaurora.org" , "cloud.chou@mediatek.com" , "frederic.chen@mediatek.com" Date: Fri, 24 Jul 2015 13:43:13 +0800 In-Reply-To: <20150721145910.GG31095@arm.com> References: <1437037475-9065-1-git-send-email-yong.wu@mediatek.com> <1437037475-9065-6-git-send-email-yong.wu@mediatek.com> <20150721145910.GG31095@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1905 Lines: 56 On Tue, 2015-07-21 at 15:59 +0100, Will Deacon wrote: > Hi Yong Wu, > > On Thu, Jul 16, 2015 at 10:04:34AM +0100, Yong Wu wrote: > > This patch adds support for mediatek m4u (MultiMedia Memory Management > > Unit). > > [...] > > > +static void mtk_iommu_tlb_flush_all(void *cookie) > > +{ > > + struct mtk_iommu_domain *domain = cookie; > > + void __iomem *base; > > + > > + base = domain->data->base; > > + writel(F_INVLD_EN1 | F_INVLD_EN0, base + REG_MMU_INV_SEL); > > + writel(F_ALL_INVLD, base + REG_MMU_INVALIDATE); > > This needs to be synchronous, so you probably want to call > mtk_iommu_tlb_sync at the end. >From our spec, we have to wait until HW done after tlb flush range. But it don't need wait after tlb flush all. so It isn't necessary to add mtk_iommu_tlb_sync in tlb_flush_all here. > > > +} > > + > > +static void mtk_iommu_tlb_add_flush(unsigned long iova, size_t size, > > + bool leaf, void *cookie) > > +{ > > + struct mtk_iommu_domain *domain = cookie; > > + void __iomem *base = domain->data->base; > > + unsigned int iova_start = iova, iova_end = iova + size - 1; > > + > > + writel(F_INVLD_EN1 | F_INVLD_EN0, base + REG_MMU_INV_SEL); > > + > > + writel(iova_start, base + REG_MMU_INVLD_START_A); > > + writel(iova_end, base + REG_MMU_INVLD_END_A); > > + writel(F_MMU_INV_RANGE, base + REG_MMU_INVALIDATE); > > Why are you using writel instead of writel_relaxed? I asked this before > but I don't think you replied. Sorry, I didn't notice _relax last time. I will improve in next version. Thanks very much. > > Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/