Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbbGXJt5 (ORCPT ); Fri, 24 Jul 2015 05:49:57 -0400 Received: from smtp.citrix.com ([66.165.176.89]:16173 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752847AbbGXJtz (ORCPT ); Fri, 24 Jul 2015 05:49:55 -0400 X-IronPort-AV: E=Sophos;i="5.15,537,1432598400"; d="scan'208";a="284022698" Message-ID: <55B20A3F.4000408@citrix.com> Date: Fri, 24 Jul 2015 10:49:51 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Julien Grall , CC: , , , , "Konrad Rzeszutek Wilk" , Boris Ostrovsky Subject: Re: [PATCH v2 10/20] xen/xenbus: Use Xen page definition References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-11-git-send-email-julien.grall@citrix.com> In-Reply-To: <1436474552-31789-11-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 790 Lines: 25 On 09/07/15 21:42, Julien Grall wrote: > All the ring (xenstore, and PV rings) are always based on the page > granularity of Xen. [...] > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -713,7 +713,7 @@ static int __init xenstored_local_init(void) > > xen_store_mfn = xen_start_info->store_mfn = > pfn_to_mfn(virt_to_phys((void *)page) >> > - PAGE_SHIFT); > + XEN_PAGE_SHIFT); xen_store_pfn = xen_page_to_gfn(page); Otherwise, Reviewed-by: David Vrabel David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/