Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753557AbbGXLcz (ORCPT ); Fri, 24 Jul 2015 07:32:55 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:34292 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563AbbGXLcw (ORCPT ); Fri, 24 Jul 2015 07:32:52 -0400 MIME-Version: 1.0 In-Reply-To: <1437706925-3222-8-git-send-email-jamesjj.liao@mediatek.com> References: <1437706925-3222-1-git-send-email-jamesjj.liao@mediatek.com> <1437706925-3222-8-git-send-email-jamesjj.liao@mediatek.com> From: Daniel Kurtz Date: Fri, 24 Jul 2015 19:32:32 +0800 X-Google-Sender-Auth: 2pTcVpCINCZvBYYe_ZZL2WnQWzg Message-ID: Subject: Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes To: James Liao Cc: Matthias Brugger , Mike Turquette , Stephen Boyd , Heiko Stubner , srv_heupstream , Ricky Liang , Rob Herring , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3007 Lines: 84 On Fri, Jul 24, 2015 at 11:02 AM, James Liao wrote: > This patch adds device nodes providing subsystem clocks on MT8173, > includes mmsys, imgsys, vdecsys, vencsys and vencltsys. > > Signed-off-by: James Liao > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 ++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index a2f63e4..8731d24 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -88,6 +88,13 @@ > #clock-cells = <0>; > }; > > + cpum_ck: dummy_clk { I'm not a big fan of this "dummy_clk". The 'name' part of the devicetree node is supposed to be generic. So, perhaps just oscillator@2, and move it down below clk32k: oscillator@1. Otherwise: Reviewed-by: Daniel Kurtz -Dan > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + clock-output-names = "cpum_ck"; > + }; > + > clk26m: oscillator@0 { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -227,6 +234,36 @@ > clocks = <&uart_clk>; > status = "disabled"; > }; > + > + mmsys: clock-controller@14000000 { > + compatible = "mediatek,mt8173-mmsys", "syscon"; > + reg = <0 0x14000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + imgsys: clock-controller@15000000 { > + compatible = "mediatek,mt8173-imgsys", "syscon"; > + reg = <0 0x15000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vdecsys: clock-controller@16000000 { > + compatible = "mediatek,mt8173-vdecsys", "syscon"; > + reg = <0 0x16000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vencsys: clock-controller@18000000 { > + compatible = "mediatek,mt8173-vencsys", "syscon"; > + reg = <0 0x18000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vencltsys: clock-controller@19000000 { > + compatible = "mediatek,mt8173-vencltsys", "syscon"; > + reg = <0 0x19000000 0 0x1000>; > + #clock-cells = <1>; > + }; > }; > }; > > -- > 1.8.1.1.dirty > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/