Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbbGXM0a (ORCPT ); Fri, 24 Jul 2015 08:26:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:53901 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbbGXM01 (ORCPT ); Fri, 24 Jul 2015 08:26:27 -0400 Date: Fri, 24 Jul 2015 14:26:22 +0200 From: Sebastian Reichel To: Vaishali Thakkar Cc: Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power_supply: Adjust devm usage Message-ID: <20150724122622.GA22105@earth> References: <20150724115813.GA3004@vaishali-Ideapad-Z570> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u3/rZRmxL6MmkK24" Content-Disposition: inline In-Reply-To: <20150724115813.GA3004@vaishali-Ideapad-Z570> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1973 Lines: 57 --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Thanks for the cleanup patch. I have a couple of comments inlined. > Subject: Re: [PATCH] power_supply: Adjust devm usage Please make this "power_supply: bq24735: ...". On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote: > Use devm_kasprintf instead of kasprintf. Also, remove various > gotos by direct returns and drop unneeded label err_free_name. Please also use devm_power_supply_unregister() instead of power_supply_unregister() to further simplify the driver. > @@ -267,8 +267,9 @@ static int bq24735_charger_probe() {} > [...] Your patch is missing removal of the kfree(charger->charger_desc.name) in bq24735_charger_remove(). -- Sebastian --u3/rZRmxL6MmkK24 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVsi7qAAoJENju1/PIO/qaS8kP+wceDnvo4J/FQS8j+2CS9F2P e/T3o7FxYbfcvBV16nuc8Lr4CWDQxOvcHw38AappjqgiDXW2FWkEGFbLK9zd+xIC dG2XEtvKEsNrrSkT9K3SrkQzzuX2VGGLx4bd9AXS9ZxhRngE8o6sF+Kln0CnED1+ Jjlvvxo9SMxiFaFY+d5E0lj4wTDTnVtc7jOhqojf3jpejsNfnntgeqkuuFhO0fTX 24JkuDXTSLNcMc52N0ZdPLjAh/89BXE1BEMuepSYiaIftf2fUaymLmpm3MfG76Gv 4/DRas2cvlk7qRrxB5R7PjeUVL3Kc758SrKgzbfGZJPMGTCfIh9rl+rA0VVVU4DC Orb6Mfm+FSoUP+3rvvcCc5/BQ//ealhPJhCyanuLC3CJ6zjcPB7m23iBtOp9bJs5 kyeNPhfvCmOQ1prW5eXCTcO2rdub2jraCdwKQrAxEU05JGV5EsvOYGr+sHiGja9a D+wWvoAusH5aYwkRyn2RcK1ISpiedjzQ3yuFZAuD4fU0Y65um56dliWB7R8afizC Tj2jdT2ZJF5pxOeLRRot2OBZJ1i48zQgbQ71+HkZLTv3QfyfsiXTK4JGqS4VrYcx Cpm5uZ7fgCNNhdQX2I1Pyxib9sibjLgIl56rhvYLGfDttqG3VzSk1rzqqOzA87He CXwZgDjmyZYvnClE7nTx =3LXl -----END PGP SIGNATURE----- --u3/rZRmxL6MmkK24-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/