Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753421AbbGXM33 (ORCPT ); Fri, 24 Jul 2015 08:29:29 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:34917 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751136AbbGXM30 (ORCPT ); Fri, 24 Jul 2015 08:29:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150724115813.GA3004@vaishali-Ideapad-Z570> Date: Fri, 24 Jul 2015 21:29:25 +0900 X-Google-Sender-Auth: MPa4YyMC9nLA-EviVX1SAbYevZc Message-ID: Subject: Re: [PATCH] power_supply: Adjust devm usage From: Krzysztof Kozlowski To: Vaishali Thakkar Cc: Sebastian Reichel , Frans Klaver , Dmitry Eremin-Solenikov , David Woodhouse , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 24 2015-07-24 21:17 GMT+09:00 Frans Klaver : > Hi, > > On Fri, Jul 24, 2015 at 1:58 PM, Vaishali Thakkar > wrote: >> Use devm_kasprintf instead of kasprintf. Also, remove various >> gotos by direct returns and drop unneeded label err_free_name. > > If there's to be a respin, reword this so that it becomes clearer that > removing the various gotos and the label is an effect of using > devm_kasprintf here. I started out thinking that this patch did two > things. And please put a driver prefix in the subject (like in rest of commits). Beside of that: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/