Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbbGXMdl (ORCPT ); Fri, 24 Jul 2015 08:33:41 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37640 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbbGXMdj (ORCPT ); Fri, 24 Jul 2015 08:33:39 -0400 MIME-Version: 1.0 In-Reply-To: <20150724122622.GA22105@earth> References: <20150724115813.GA3004@vaishali-Ideapad-Z570> <20150724122622.GA22105@earth> Date: Fri, 24 Jul 2015 18:03:38 +0530 Message-ID: Subject: Re: [PATCH] power_supply: Adjust devm usage From: Vaishali Thakkar To: Sebastian Reichel Cc: Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 46 On Fri, Jul 24, 2015 at 5:56 PM, Sebastian Reichel wrote: > Hi, Hi > Thanks for the cleanup patch. > I have a couple of comments inlined. > >> Subject: Re: [PATCH] power_supply: Adjust devm usage > > Please make this "power_supply: bq24735: ...". Ok. Sure. > On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote: >> Use devm_kasprintf instead of kasprintf. Also, remove various >> gotos by direct returns and drop unneeded label err_free_name. > > Please also use devm_power_supply_unregister() instead > of power_supply_unregister() to further simplify the driver. Ok. >> @@ -267,8 +267,9 @@ static int bq24735_charger_probe() {} >> [...] > > Your patch is missing removal of the > kfree(charger->charger_desc.name) in bq24735_charger_remove(). Yes. Because it seems that this kfree is freeing some other data which is not related to devm_kzalloc. I was not sure about removing it. So, I was about to discuss it in a separate thread. Also, in the remove function we have devm_free_irq. I am unsure it too. Because normally remove functions do not use devm counterparts. > -- Sebastian -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/