Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754056AbbGXMjP (ORCPT ); Fri, 24 Jul 2015 08:39:15 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:38007 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbbGXMjN (ORCPT ); Fri, 24 Jul 2015 08:39:13 -0400 MIME-Version: 1.0 In-Reply-To: <20150724122622.GA22105@earth> References: <20150724115813.GA3004@vaishali-Ideapad-Z570> <20150724122622.GA22105@earth> Date: Fri, 24 Jul 2015 14:39:12 +0200 Message-ID: Subject: Re: [PATCH] power_supply: Adjust devm usage From: Frans Klaver To: Sebastian Reichel Cc: Vaishali Thakkar , Dmitry Eremin-Solenikov , David Woodhouse , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 869 Lines: 25 On Fri, Jul 24, 2015 at 2:26 PM, Sebastian Reichel wrote: > Hi, > > Thanks for the cleanup patch. > I have a couple of comments inlined. > >> Subject: Re: [PATCH] power_supply: Adjust devm usage > > Please make this "power_supply: bq24735: ...". > > On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote: >> Use devm_kasprintf instead of kasprintf. Also, remove various >> gotos by direct returns and drop unneeded label err_free_name. > > Please also use devm_power_supply_unregister() instead > of power_supply_unregister() to further simplify the driver. Sounds like a separate patch. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/