Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754209AbbGXNOo (ORCPT ); Fri, 24 Jul 2015 09:14:44 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35057 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752299AbbGXNOm (ORCPT ); Fri, 24 Jul 2015 09:14:42 -0400 MIME-Version: 1.0 In-Reply-To: <20150724125951.GA25447@earth> References: <20150724115813.GA3004@vaishali-Ideapad-Z570> <20150724122622.GA22105@earth> <20150724125951.GA25447@earth> Date: Fri, 24 Jul 2015 18:44:41 +0530 Message-ID: Subject: Re: [PATCH] power_supply: Adjust devm usage From: Vaishali Thakkar To: Sebastian Reichel Cc: Dmitry Eremin-Solenikov , David Woodhouse , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Frans Klaver Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 53 On Fri, Jul 24, 2015 at 6:29 PM, Sebastian Reichel wrote: > Hi, > > On Fri, Jul 24, 2015 at 06:03:38PM +0530, Vaishali Thakkar wrote: >> On Fri, Jul 24, 2015 at 5:56 PM, Sebastian Reichel wrote: >> > On Fri, Jul 24, 2015 at 05:28:13PM +0530, Vaishali Thakkar wrote: >> >> @@ -267,8 +267,9 @@ static int bq24735_charger_probe() {} >> >> [...] >> > >> > Your patch is missing removal of the >> > kfree(charger->charger_desc.name) in bq24735_charger_remove(). >> >> Yes. Because it seems that this kfree is freeing some other data which >> is not related to devm_kzalloc. I was not sure about removing it. >> So, I was about to discuss it in a separate thread.s > > it's assigned in the probe function: > > name = kasprintf(...); > ... > supply_desc->name = name; > ... > power_supply_register(..., supply_desc, ...); > Oh. Yes. I missed that. >> Also, in the remove function we have devm_free_irq. I am unsure it >> too. Because normally remove functions do not use devm >> counterparts. > > It's required to free the irq before removing the power supply > device. > > If the power supply is registered with devm, that should happen > automatically, since it is requested before the irq. Thus the > remove function can be removed completely at that point :) This makes sense. Thanks for explanation and review :) So, can I send all changes along with getting rid of remove function here in a single patch? > -- Sebastian -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/