Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576AbbGXNS3 (ORCPT ); Fri, 24 Jul 2015 09:18:29 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:34873 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111AbbGXNS1 (ORCPT ); Fri, 24 Jul 2015 09:18:27 -0400 MIME-Version: 1.0 X-Originating-IP: [37.11.3.119] In-Reply-To: <1437742798.30329.100.camel@mtksdaap41> References: <1437715481-31528-1-git-send-email-henryc.chen@mediatek.com> <1437715481-31528-2-git-send-email-henryc.chen@mediatek.com> <1437742798.30329.100.camel@mtksdaap41> Date: Fri, 24 Jul 2015 15:18:27 +0200 Message-ID: Subject: Re: [PATCH v4 1/2] dt-bindings: regulator: mt6311: Add document for mt6311 regulator From: Javier Martinez Canillas To: Henry Chen Cc: Mark Brown , Mark Rutland , Liam Girdwood , Linux Kernel , linux-mediatek@lists.infradead.org, Sascha Hauer , Matthias Brugger , eddie.huang@mediatek.com, "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 48 Hello Henry, On Fri, Jul 24, 2015 at 2:59 PM, Henry Chen wrote: > Hi Javier, > > On Fri, 2015-07-24 at 10:32 +0200, Javier Martinez Canillas wrote: >> Hello Henry, >> >> I believe Mark asked you to use a subject lines reflecting the style >> for the subsystem, so the subject should had been something like: >> >> regulators: mt6311: Add DT binding document >> >> On Fri, Jul 24, 2015 at 7:24 AM, Henry Chen wrote: >> > This patch adds a list of supported regulator names to the devicetree >> > binding documentation for Mediatek MT6311 PMIC. >> > >> > Signed-off-by: Henry Chen >> > --- >> >> I know is in your cover letter, but usually is good to also include a >> history log of the changes for each patch so people know what changed. >> Everything between the '---' and the diff are omitted by tools like >> git am so you can add there. You can use tools like patman that do >> this automatically for you. >> > Ok, got it, I will follow that. > >> Also, I said that you could add my Reviewed-by after the node name >> change so you should had carried that. So again: > > Sorry, did you mean I need to resent again? > Sorry for not being clear. No, it's not necessary to resend. I just mentioned for the next time. > Thanks for advise. > Henry > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/