Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754384AbbGXNx3 (ORCPT ); Fri, 24 Jul 2015 09:53:29 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35636 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753568AbbGXNx1 (ORCPT ); Fri, 24 Jul 2015 09:53:27 -0400 From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu Cc: Weijun Yang , Andrew Bresticker , Jean Delvare , Srinivas Kandagatla , linux-mmc@vger.kernel.org, Alim Akhtar , Scott Branden , addy ke , Stephen Boyd , Chaotian Jing , Georgi Djakov , Kevin Hao , Vincent Yang , Ulf Hansson Subject: [RFC PATCH] mmc: Kconfig: Add dependency on GPIOLIB for Arasan driver Date: Fri, 24 Jul 2015 15:53:16 +0200 Message-Id: <920802cde8579bdfad47baba85d85212735ed90e.1437745991.git.michal.simek@xilinx.com> X-Mailer: git-send-email 2.3.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1374 Lines: 41 The patch "mmc: sdhci-of-arasan: Call OF parsing for MMC" (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) introduce new dependency on GPIOLIB which calls mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which calls devm_gpiod_get_index() which returns -ENOSYS. Error log: sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258) sdhci-arasan: probe of ff160000.sdhci failed with error -38 Signed-off-by: Michal Simek --- This problem is probably in all others drivers. This is one way how this can be solved. Maybe better way is to block return value for cd and wp. --- drivers/mmc/host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index fd9a58e216a5..4b5854759cfc 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -120,6 +120,7 @@ config MMC_SDHCI_PLTFM config MMC_SDHCI_OF_ARASAN tristate "SDHCI OF support for the Arasan SDHCI controllers" depends on MMC_SDHCI_PLTFM + depends on GPIOLIB depends on OF help This selects the Arasan Secure Digital Host Controller Interface -- 2.3.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/