From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
To: Joe Perches <joe@perches.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Scott Wood <scottwood@freescale.com>,
        Liberman Igal <Igal.Liberman@freescale.com>,
        "ppc@mindchasers.com" <ppc@mindchasers.com>,
        "pebolle@tiscali.nl" <pebolle@tiscali.nl>,
        "joakim.tjernlund@transmode.se" <joakim.tjernlund@transmode.se>
Subject: RE: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds
Thread-Topic: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds
Thread-Index: AQHQxJn/ayRE53kbD0+lkRb1eflMup3nw6cAgAMAN4A=
Date: Fri, 24 Jul 2015 15:49:39 +0000
Message-ID: <BL2PR03MB545AA0E6D98232FF43B6CE9E6810@BL2PR03MB545.namprd03.prod.outlook.com>
References: <1437581806-17420-1-git-send-email-madalin.bucur@freescale.com>
	 <1437581806-17420-2-git-send-email-madalin.bucur@freescale.com>
	 <1437581806-17420-3-git-send-email-madalin.bucur@freescale.com>
 <1437587228.20787.26.camel@perches.com>
In-Reply-To: <1437587228.20787.26.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2015 15:49:39.6368
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB371
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1788
Lines: 44

> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote:
> > Allow the user to tweak the refill threshold and the total number
> > of buffers in the buffer pool. The provided values are for one CPU.
> 
> Any value in making these module parameters instead?

I expect one would (hardly ever) change these to improve some corner
cases then use them with the new values. It may help in the tuning process
but afterwards the bloat to the bootcmd would probably be  a nuisance.

> > +config FSL_DPAA_ETH_MAX_BUF_COUNT
> > +	int "Maximum number of buffers in private bpool"
> > +	range 64 2048
> > +	default "128"
> > +	---help---
> > +	  The maximum number of buffers to be by default allocated in the
> DPAA-Ethernet private port's
> > +	  buffer pool. One needn't normally modify this, as it has probably
> been tuned for performance
> > +	  already. This cannot be lower than DPAA_ETH_REFILL_THRESHOLD.
> > +
> > +config FSL_DPAA_ETH_REFILL_THRESHOLD
> > +	int "Private bpool refill threshold"
> > +	range 32 FSL_DPAA_ETH_MAX_BUF_COUNT
> > +	default "80"
> > +	---help---
> > +	  The DPAA-Ethernet driver will start replenishing buffer pools whose
> count
> > +	  falls below this threshold. This must be related to
> DPAA_ETH_MAX_BUF_COUNT. One needn't normally
> > +	  modify this value unless one has very specific performance reasons.
> > +
> >  config FSL_DPAA_CS_THRESHOLD_1G
> >  	hex "Egress congestion threshold on 1G ports"
> >  	range 0x1000 0x10000000
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/