Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753868AbbGXQbJ (ORCPT ); Fri, 24 Jul 2015 12:31:09 -0400 Received: from smtprelay0062.hostedemail.com ([216.40.44.62]:39353 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752941AbbGXQbH (ORCPT ); Fri, 24 Jul 2015 12:31:07 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3350:3622:3865:3867:3871:3872:3874:4321:5007:6119:6261:7875:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: tooth11_436b372f74143 X-Filterd-Recvd-Size: 2131 Date: Fri, 24 Jul 2015 12:31:02 -0400 From: Steven Rostedt To: Willy Tarreau Cc: Andy Lutomirski , Peter Zijlstra , Linus Torvalds , X86 ML , "linux-kernel@vger.kernel.org" , Borislav Petkov , Thomas Gleixner , Brian Gerst Subject: Re: Dealing with the NMI mess Message-ID: <20150724123102.376c0a99@gandalf.local.home> In-Reply-To: <20150724160806.GF3612@1wt.eu> References: <20150723173105.6795c0dc@gandalf.local.home> <20150724081326.GO25159@twins.programming.kicks-ass.net> <20150724120249.1ba0d9de@gandalf.local.home> <20150724160806.GF3612@1wt.eu> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 23 On Fri, 24 Jul 2015 18:08:06 +0200 Willy Tarreau wrote: > > Um, isn't 0xf * DR_TRAP0 same as a constant "true"? > > For me it's a typo, it should have been : > > if ((dr6 & (0xf * DR_TRAP0) && (regs->flags & (X86_EFLAGS_RF | > > (the purpose was to read all 4 lower bits at once). I figured that after I sent it, but the 0xf * DR_TRAP0 is also confusing to me. Actually, why not use proper naming: dr6 & DR_TRAP_BITS -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/