Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507AbbGXQlu (ORCPT ); Fri, 24 Jul 2015 12:41:50 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:22396 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754240AbbGXQls convert rfc822-to-8bit (ORCPT ); Fri, 24 Jul 2015 12:41:48 -0400 Message-ID: <55B26AC9.5040508@arm.com> Date: Fri, 24 Jul 2015 17:41:45 +0100 From: Dietmar Eggemann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yuyang Du , "mingo@kernel.org" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" CC: "pjt@google.com" , "bsegall@google.com" , Morten Rasmussen , "vincent.guittot@linaro.org" , "umgwanakikbuti@gmail.com" , "len.brown@intel.com" , "rafael.j.wysocki@intel.com" , "arjan@linux.intel.com" , "fengguang.wu@intel.com" Subject: Re: [PATCH v10 7/7] sched: Clean up load average references References: <1436918682-4971-1-git-send-email-yuyang.du@intel.com> <1436918682-4971-8-git-send-email-yuyang.du@intel.com> In-Reply-To: <1436918682-4971-8-git-send-email-yuyang.du@intel.com> X-OriginalArrivalTime: 24 Jul 2015 16:41:46.0133 (UTC) FILETIME=[A10A8C50:01D0C62F] X-MC-Unique: sSgfAqUfRv6AJtsCYYx5SA-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1527 Lines: 41 On 15/07/15 01:04, Yuyang Du wrote: > For cfs_rq, we have load.weight, runnable_load_avg, and load_avg. We > now start to clean up how they are used. > > First, as group sched_entity already largely uses load_avg, we now expand > to use load_avg in all cases. You're talking about group se's or cfs_rq owned by the group se's (se->my_q) here or both? Just asking because both data structures (cfs_rq and se) have a 'struct load_weight load' as well as 'struct sched_avg avg' member. Second, for CPU-wide load balancing, we > choose to use runnable_load_avg in all cases, which is the same as before > this series. With your patch-set there will be still the difference of 'cfs_rq->utilization_load_avg' and your 'cfs_rq->avg.util_avg' in the sense that the former one does not contain the contribution of blocked se's. The EAS patch-set adds blocked utilization contribution: https://lkml.org/lkml/2015/7/7/915 The cfs_rq utilization is also used by the load-balancer code via get_cpu_usage() so the blocked utilization contribution to 'cfs_rq->avg.util_avg' can change load-balancing as well. Since it is not as heavily used as the cfs_rq->runnable_load_avg we might not need to reintroduce cfs_rq->utilization_load_avg but at least mention this here. -- Dietmar [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/